-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MIPS: Fix asm constraints "f" and "r" for softfloat (#79116)
This include 2 fixes: 1. Disallow 'f' for softfloat. 2. Allow 'r' for softfloat. Currently, 'f' is accpeted by clang, then LLVM meets an internal error. 'r' is rejected by LLVM by: couldn't allocate input reg for constraint 'r'. Fixes: #64241, #63632 --------- Co-authored-by: Fangrui Song <[email protected]> (cherry picked from commit c88beb4)
- Loading branch information
Showing
5 changed files
with
78 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// RUN: %clang_cc1 -emit-llvm -triple mips -target-feature +soft-float %s -o - | FileCheck %s --check-prefix=SOFT_FLOAT | ||
|
||
// SOFT_FLOAT: call void asm sideeffect "", "r,~{$1}"(float %1) | ||
void read_float(float *p) { | ||
__asm__("" ::"r"(*p)); | ||
} | ||
|
||
// SOFT_FLOAT: call void asm sideeffect "", "r,~{$1}"(double %1) | ||
void read_double(double *p) { | ||
__asm__("" :: "r"(*p)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// RUN: %clang_cc1 -triple mips64 -fsyntax-only -verify %s | ||
// RUN: %clang_cc1 -triple mips64 -target-feature +soft-float -fsyntax-only -verify=softfloat %s | ||
|
||
// expected-no-diagnostics | ||
|
||
void test_f(float p) { | ||
float result = p; | ||
__asm__("" :: "f"(result)); // softfloat-error{{invalid input constraint 'f' in asm}} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 | ||
; RUN: llc -march=mips < %s | FileCheck %s --check-prefix=MIPS32 | ||
; RUN: llc -march=mips64 < %s | FileCheck %s --check-prefix=MIPS64 | ||
|
||
define dso_local void @read_double(ptr nocapture noundef readonly %0) local_unnamed_addr #0 { | ||
; MIPS32-LABEL: read_double: | ||
; MIPS32: # %bb.0: | ||
; MIPS32-NEXT: lw $2, 4($4) | ||
; MIPS32-NEXT: lw $3, 0($4) | ||
; MIPS32-NEXT: #APP | ||
; MIPS32-NEXT: #NO_APP | ||
; MIPS32-NEXT: jr $ra | ||
; MIPS32-NEXT: nop | ||
; | ||
; MIPS64-LABEL: read_double: | ||
; MIPS64: # %bb.0: | ||
; MIPS64-NEXT: ld $2, 0($4) | ||
; MIPS64-NEXT: #APP | ||
; MIPS64-NEXT: #NO_APP | ||
; MIPS64-NEXT: jr $ra | ||
; MIPS64-NEXT: nop | ||
%2 = load double, ptr %0, align 8 | ||
tail call void asm sideeffect "", "r,~{$1}"(double %2) | ||
ret void | ||
} | ||
|
||
define dso_local void @read_float(ptr nocapture noundef readonly %0) local_unnamed_addr #0 { | ||
; MIPS32-LABEL: read_float: | ||
; MIPS32: # %bb.0: | ||
; MIPS32-NEXT: lw $2, 0($4) | ||
; MIPS32-NEXT: #APP | ||
; MIPS32-NEXT: #NO_APP | ||
; MIPS32-NEXT: jr $ra | ||
; MIPS32-NEXT: nop | ||
; | ||
; MIPS64-LABEL: read_float: | ||
; MIPS64: # %bb.0: | ||
; MIPS64-NEXT: lw $2, 0($4) | ||
; MIPS64-NEXT: #APP | ||
; MIPS64-NEXT: #NO_APP | ||
; MIPS64-NEXT: jr $ra | ||
; MIPS64-NEXT: nop | ||
%2 = load float, ptr %0, align 8 | ||
tail call void asm sideeffect "", "r,~{$1}"(float %2) | ||
ret void | ||
} | ||
|
||
attributes #0 = { "target-features"="+soft-float" "use-soft-float"="true" } |