Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of CNil #96

Open
Centril opened this issue Mar 21, 2018 · 4 comments
Open

Getting rid of CNil #96

Centril opened this issue Mar 21, 2018 · 4 comments

Comments

@Centril
Copy link
Collaborator

Centril commented Mar 21, 2018

This is a follow up issue to #93.

I think we should get rid of special uninhabited types unless we have a particularly good reason to keep them. The standard library is in the process of getting rid of Infallible and other uninhabited types.

So I think we should replace CNil and Here with just !.

Thoughts?

@ExpHP
Copy link
Collaborator

ExpHP commented Mar 21, 2018

Please do not replace Here with ! because I plan to turn it into a unit struct. (for reified indices)

@Centril
Copy link
Collaborator Author

Centril commented Mar 22, 2018

@ExpHP Ah right; sounds like a good idea =)

@lloydmeta
Copy link
Owner

Interesting; I guess the empty enum trick has fallen out of fashion :)

Here aside, should we wait until ! as a type is stabilised before going ahead with getting rid of CNil? I'm not fully sure if it's done yet because these are still open

@Centril
Copy link
Collaborator Author

Centril commented Mar 22, 2018

Yeah, I think we should wait until it is stabilised.

@Centril Centril changed the title Getting rid of CNil / Here Getting rid of CNil Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants