Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add support for https #813

Open
ykhemani opened this issue Jan 23, 2024 · 5 comments
Open

[FEATURE REQUEST] Add support for https #813

ykhemani opened this issue Jan 23, 2024 · 5 comments
Labels
backend Issues that require a backend change enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Pull requests that update Rust code

Comments

@ykhemani
Copy link

Motivation
Allow secure (https) communication for the web interface to lldap so that communication between the browser and lldap isn't in plaintext.

Describe the solution you'd like

  • Add support for environment variable to add enable https (LLDAP_HTTPS_OPTIONS__ENABLED). Default to false. Set to true to enable https.
  • Add support for environment variable to set https private key file (LLDAP_HTTPS_OPTIONS__KEY_FILE).
  • Add support for environment variable to set https cert file ( LLDAP_HTTPS_OPTIONS__CERT_FILE). Can contain just the certificate or the cert and cert chain.
  • Add support for environment variable to set https CA cert file ( LLDAP_HTTPS_OPTIONS__CA_CERT_FILE). Can contain the CA cert.

Describe alternatives you've considered
You could use a reverse proxy and have it terminate TLS. The connection from the reverse proxy to lldap would still be clear text, of course.

@ykhemani ykhemani added the enhancement New feature or request label Jan 23, 2024
@nitnelave
Copy link
Member

Reverse proxy is the recommended setup. Is there any reason that doesn't work for you?

@ykhemani
Copy link
Author

Reverse proxy is the recommended setup. Is there any reason that doesn't work for you?

Indeed, it can work. Having this allows you to have end-to-end encryption without another layer.

@nitnelave
Copy link
Member

Alright, since we have a working solution, I'm not going to fix it myself. If someone wants to come and implement it, be my guest.

@nitnelave nitnelave added help wanted Extra attention is needed good first issue Good for newcomers backend Issues that require a backend change rust Pull requests that update Rust code labels Jan 24, 2024
@fsdrw08
Copy link

fsdrw08 commented Apr 10, 2024

Any updates for this request?

@nitnelave
Copy link
Member

Any updates for this request?

See the message above: I'm not going to work on that, but I'll accept contributions.

Note that a reverse proxy that provides HTTPS to the external world but HTTP inside the host is often more than enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues that require a backend change enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

3 participants