Skip to content

500 error when character on sale is deleted #459

Open
@SpeedyD

Description

@SpeedyD

Bug as reported:

(Main branch, last commit parent: da3ebb11)

URL of page: <site>/sales, <site>/sales/<id> and <site>/admin/sales/edit/<id> (where is the id of the sale in question)
Description of bug: When a character has been deleted entirely, and they were part of a sales post, the sale in question as well as the admin page on which it is editable, will give out a 500 error. (And of course any of the sales pages that sale is displayed on.)
How was the bug caused (exact steps to reproduce): Add a character to a sale. Delete the character. Go to the sale in either public area or the editing page of the admin section.

Further details

..Yeah, I guess this is a thing that happens. Should be a decently easy fix, just have a check if it exists and if not display something like 'Character Not Found' like with gallery images.

PR #462 should fix this, eventually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions