Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous name appearing despite no name changes #1115

Open
ScuffedNewt opened this issue Nov 8, 2024 · 5 comments · Fixed by #1116
Open

Previous name appearing despite no name changes #1115

ScuffedNewt opened this issue Nov 8, 2024 · 5 comments · Fixed by #1116
Labels
bug Something isn't working

Comments

@ScuffedNewt
Copy link
Contributor

https://github.com/corowne/lorekeeper/blob/354c1aac01b16d0a5b239ec430d0c2fdd8acc8c0/app/Models/User/User.php#L338

I believe the changes made by @SpeedyD where reverted somehow?
@itinerare itinerare added the bug Something isn't working label Nov 8, 2024
@SpeedyD
Copy link
Contributor

SpeedyD commented Nov 8, 2024

...Even weirder: History for the file on the dev branch doesn't even show my change..

@SpeedyD
Copy link
Contributor

SpeedyD commented Nov 8, 2024 •
edited
Loading

WAIT! #763 is where I did the fix.. To resources/views/user/profile.blade.php.

There's no check on the Username in the model.. This.. IS.. what you were looking for, right, @ScuffedNewt?

@ScuffedNewt
Copy link
Contributor Author

the add_help next to the display name still shows, maybe that's something else? not sure, it checks against this attribute

@SpeedyD
Copy link
Contributor

SpeedyD commented Nov 9, 2024

..That would be resources/views/user/_profile_content.blade.php. I'll make a bug fix PR for that in a moment.

@SpeedyD SpeedyD mentioned this issue Nov 9, 2024
Merged
@ScuffedNewt
Copy link
Contributor Author

Closed by #1116

@itinerare itinerare linked a pull request Nov 10, 2024 that will close this issue
fix(userprofile): Add check if previousUsername isnt identical to the current username #1116
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@SpeedyD @itinerare @ScuffedNewt