Skip to content

Adding drag-drop-touch for mobile sorting #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notecardPasta opened this issue Nov 4, 2024 · 7 comments · Fixed by #1111
Open

Adding drag-drop-touch for mobile sorting #1110

notecardPasta opened this issue Nov 4, 2024 · 7 comments · Fixed by #1111
Labels
enhancement New feature or request

Comments

@notecardPasta
Copy link

https://www.npmjs.com/package/drag-drop-touch

I've had this package manually added to one of the JS folders for a while and it works pretty well on to fix touchscreens not liking the drag-and-drop in the character sort page (you add draggable="true" to the div under the foreach in characters.blade.php in home)

Maybe it can be added to dev or v3? I don't know which JS folder is best to put it in or how to hook up packages installed via NPM myself though (like bootstrap) if that'd be more efficient than my temp implementation though

@liwoyadan
Copy link

@notecardPasta
Copy link
Author

Oh nice! I definitely think something like this could be added to dev rather than be an ext since it adds functionality for mobile users

@SpeedyD
Copy link
Contributor

SpeedyD commented Nov 4, 2024

If @liwoyadan wants to add it to dev, I personally don't see why not. It is functionality that should be added.. However, since this is in fact a new functionality, it should be added to the develop branch (which is informally known as v3.1).

So, if liwoyadan wants to start a PR on this (or gives you, @notecardPasta, permission to do so instead), my vote is sure, why not.

@itinerare
Copy link
Member

I'm in favor of adding some variety of this to dev, yeah. A lot of folks use LK sites on mobile, so it makes a lot of sense to me.

@itinerare itinerare added the enhancement New feature or request label Nov 4, 2024
@liwoyadan
Copy link

Oh yes, sure! I can absolutely toss the extension I have onto a dev branch and PR it in, while keeping the v3 extension up for anyone not on dev who wants to add the functionality to their site. The nice thing about the touch-punch library is that it doesn't require any further editing to any pieces of code outside of just including the js file in your app blade. I'll go ahead and set that branch up soon. 👍

@itinerare
Copy link
Member

Oh, nice! Much appreciated.

@ScuffedNewt
Copy link
Contributor

Closed by #1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants