-
Notifications
You must be signed in to change notification settings - Fork 139
Adding drag-drop-touch for mobile sorting #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have an extension for this issue available already: https://github.com/liwoyadan/lorekeeper/tree/extension/touchscreen-sortable http://wiki.lorekeeper.me/index.php?title=Extensions:Touchscreen_Sortable |
Oh nice! I definitely think something like this could be added to dev rather than be an ext since it adds functionality for mobile users |
If @liwoyadan wants to add it to dev, I personally don't see why not. It is functionality that should be added.. However, since this is in fact a new functionality, it should be added to the develop branch (which is informally known as v3.1). So, if liwoyadan wants to start a PR on this (or gives you, @notecardPasta, permission to do so instead), my vote is sure, why not. |
I'm in favor of adding some variety of this to dev, yeah. A lot of folks use LK sites on mobile, so it makes a lot of sense to me. |
Oh yes, sure! I can absolutely toss the extension I have onto a dev branch and PR it in, while keeping the v3 extension up for anyone not on dev who wants to add the functionality to their site. The nice thing about the touch-punch library is that it doesn't require any further editing to any pieces of code outside of just including the js file in your app blade. I'll go ahead and set that branch up soon. 👍 |
Oh, nice! Much appreciated. |
Closed by #1111 |
https://www.npmjs.com/package/drag-drop-touch
I've had this package manually added to one of the JS folders for a while and it works pretty well on to fix touchscreens not liking the drag-and-drop in the character sort page (you add
draggable="true"
to the div under the foreach incharacters.blade.php
in home)Maybe it can be added to dev or v3? I don't know which JS folder is best to put it in or how to hook up packages installed via NPM myself though (like bootstrap) if that'd be more efficient than my temp implementation though
The text was updated successfully, but these errors were encountered: