-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runner/docker: integrate ComfyUI LivePortrait #342
base: main
Are you sure you want to change the base?
Conversation
@emranemran I've built the ComfyUI image, but I'm not sure how to use it 🙃 I see some samples in https://github.com/kijai/ComfyUI-LivePortraitKJ/tree/main/examples, I think the most closest to what we do is this one: https://github.com/kijai/ComfyUI-LivePortraitKJ/blob/main/examples/liveportrait_realtime_example_01.json But still this workflow is quite big, could you try to covert it into something that we can use in our runner, like one of these ones? https://www.notion.so/livepeer/Video-Processing-ComfyUI-Nodes-Workflows-1340a34856878005b0fcf9eb02d1819a?pvs=4#1580a348568780f1a718fbf49bf98d4c |
af4e6b9
to
d2c73ea
Compare
@leszko some notes for you:
So the previous note I shared re: comfystream supporting only a single LoadImage node can (should?) be handled with the above modified workflow if we can figure out the missing dependency. In other words, the condition here and here should still be valid and we won't need to modify comfystream for the time being (discussed with Yondon as well). Next Steps
|
One more note @leszko: i think the PreviewImage node should be replaced with the SaveImage node so that the img is returned to the pipeline. I forgot to update this in the example above. |
One more update @leszko: I was staring at the comfyui logs and noticed this:
so hopefully installing that module will get us past that missing node error. According to GPT, it's to do with some PATH thing and |
…an/integrate-comfyui-liveportrait
cd ComfyUI-KJNodes && \ | ||
pip install -r requirements.txt | ||
# Install ComfyUI-load-image-from-url Node (https://github.com/tsogzark/ComfyUI-load-image-from-url.git) | ||
RUN cd /comfyui/custom_nodes && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not build for me for some reason. But I haven't investigated yet why. I think I found the issue 👇
cd ComfyUI-load-image-from-url && \ | ||
pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd ComfyUI-load-image-from-url && \ | |
pip install -r requirements.txt | |
cd ComfyUI-load-image-from-url |
@emranemran I spent some time today on your PR. Added some inline comments. Apart from that: 1. Error "No module named 'model_management'" 2. Running E2E Error that I get:
I've created a draft PR to you branch (the intention is not merge it but rather to present what I'm talking about in points 1 and 2. #359 |
@leszko i'm seeing the same
So next steps:
|
No description provided.