Live portrait runner #199
Open
Live portrait runner #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschroedl
reviewed
Oct 23, 2024
There was a problem hiding this comment.
If we resolve the merge conflicts here by rebasing or merging in changes from main, then I think we're good to merge. Thanks @JJassonn69 !
pschroedl
reviewed
Oct 23, 2024
There was a problem hiding this comment.
We will need to add to our github actions to configure our CI to build the pipeline-specific image, as done here for Sam2:
https://github.com/livepeer/ai-worker/blob/main/.github/workflows/ai-runner-pipelines-docker.yaml
@rickstaa Unless @JJassonn69 wants to take this on, would you like to plan on a followup PR to be merged before the corresponding go-livepeer PR?
resolving the whitespace.
tidying up
added pipeline specific error
pschroedl
requested changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the new method of making container for different pipelines by first building the base image and building off the the live-portrait container.
docker build -t livepeer/ai-runner:base .docker build -f docker/Dockerfile.live-portrait -t livepeer/ai-runner:live-portrait .While building the specific docker image for live.portrait, it will automatically pull wheel from
https://github.com/JJassonn69/liveportraitand install all the necessary dependencies.