Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to runtime.Context. #2

Open
lithdew opened this issue Aug 22, 2021 · 1 comment
Open

Add timeouts to runtime.Context. #2

lithdew opened this issue Aug 22, 2021 · 1 comment

Comments

@lithdew
Copy link
Owner

lithdew commented Aug 22, 2021

A fairly common operation in code that takes in a runtime.Context is to have the runtime.Context be canceled when a timeout is exceeded. Once this is implemented, all code in Rheia which takes in a runtime.Context will be updated to cancel their passed-in Context's when a timeout is exceeded wherever necessary.

An example of some code in Rheia where timeouts are necessary and have yet to be implemented is the transaction pulling and block proposal sampling code.
@lithdew
Copy link
Owner Author

lithdew commented Sep 2, 2021

Fixed in staging branch. Will close once the branch is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lithdew