Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement(v3): Replace config objects with plugins #3388

Open
peterschutt opened this issue Apr 13, 2024 · 0 comments
Open

Enhancement(v3): Replace config objects with plugins #3388

peterschutt opened this issue Apr 13, 2024 · 0 comments
Labels
Enhancement This is a new feature or request

Comments

@peterschutt
Copy link
Contributor

peterschutt commented Apr 13, 2024

Summary

The application object accepts some config objects that we have internal special handling for, e.g., Logging, CSRF, Allowed Hosts, and CORS.

These things could be configured by plugin which would be more consistent with other things that are configured on the application, and would help reduce the number of parameters that the application object receives.

One advantage of the current setup is that we can set the explicitly put middleware for those things in the stack first, whereas via plugin we'd either need to rely on the user to order plugins appropriately, or define some prioritization scheme.

Basic Example

No response

Drawbacks and Impact

No response

Unresolved questions

No response


Note

While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.

Check out all issues funded or available for funding on our Polar.sh dashboard

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
  • This, along with engagement in the community, helps us know which features are a priority to our users.
Fund with Polar
@peterschutt peterschutt added the Enhancement This is a new feature or request label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a new feature or request
Projects
Status: Triage
Development

No branches or pull requests

1 participant