Route handler using the decorator to register

[WilliamStam]

coming over from another framework has had me scratching my head. does the router have to be added after the routes (or registered before with a .register() for each route handler?

ie:

@get("/")
async def hello_world() -> str:
    return "Hello, worldly!"


@get("/something")
async def hello_world1() -> str:
    return "Hello, something!"


router = Router(path="/", route_handlers=[hello_world, hello_world1])

or

router = Router(path="/", route_handlers=[])
@get("/")
async def hello_world() -> str:
    return "Hello, worldly!"
router.register(hello_world)

@get("/something")
async def hello_world1() -> str:
    return "Hello, something!"
router.register(hello_world)

this feels like a bunch of developer overhead. is there a reason for this? i would think attaching the route handler to the router via the decorator would make it easier

wouldn't it (or if it is.. how?) be possible to use:

router = Router(path="/", route_handlers=[])
@router.get("/")
async def hello_world() -> str:
    return "Hello, worldly!"

@router.get("/something")
async def hello_world1() -> str:
    return "Hello, something!"

[JacobCoffee]

I believe this was thoroughly discussed in https://discord.com/channels/919193495116337154/1131595764045459496/1173628032355926036 and below. If you have any more questions let us know :)

[WilliamStam]

hehe thank you!

[WilliamStam]

so PSA for anyone wanting to nest routers to the horror of some.. behold my glorious implimentation!

class InstanceController(Controller):
    @get("/")
    async def instances(self) -> str:
        return "instances"
    
    @get("/{instance_id:int}")
    async def instance(self, instance: Instance) -> str:
        
        return f"instances -> [{instance}]"


router = Router(
    "/instances",
    dependencies={"instance": Provide(get_instance)},
    route_handlers=[
        InstanceController,
        Router(
            "/{instance_id:int}",
            route_handlers=[
                accounts_router,
                financials_router
            ],
            
        )
    ]
)

accounts_router and financials_router are just imports of a router from another python file (from blah.blah.accounts.router import router as accounts_router)

ie for accounts

class AccountsController(Controller):
    @get("/",)
    async def all_accounts(self, instance: Instance) -> str:
        return f"instances -> [{instance}] -> accounts"
    
    @get("/{account_id:str}", permissions=['woof', 'meow'])
    async def an_account(self, request: Request, instance: Instance, account: Account) -> str:
        print(request.route_handler.opt)
        return f"instances -> [{instance}] -> accounts -> [{account}]"


router = Router(
    "/accounts",
    dependencies={"account": Provide(get_account)},
    route_handlers=[
        AccountsController,
        Router(
            "/{account_id:str}",
            route_handlers=[
                meters_router
            ],
        ),
    ]
)

this way if you change anything in the chain it reflects horizontally.

the Router inside the route_handlers is to be able to start a "new" segment