Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICSL value from server-side is never used. #459

Open
YuShengwei-95 opened this issue Apr 10, 2023 · 1 comment
Open

ICSL value from server-side is never used. #459

YuShengwei-95 opened this issue Apr 10, 2023 · 1 comment

Comments

@YuShengwei-95
Copy link

Hi, it seems that ICSL value from SHLO hs_ctx->icsl = get_tag_value_i32(val, len); is never used.

set_earliest_idle_alarm always uses conn->fc_settings->es_idle_conn_to instead of referring to the negotiated ICSL value.

If the server does not send a close frame when closing the connection, this will cause the client to think that the connection is still available, but will not actually receive any data from sever side.

@litespeedtech
Copy link
Owner

that's for gQUIC, not the latest IETF QUIC/HTTP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants