-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Litehtml in Claws-mail takes ages parsing a specific HTML e-mail #301
Comments
Looks like too many tables :( I'll try to do with this something. Thank you for reporting. |
I just discovered your thread about this same problem that we are having in multiple versions of claws that has been haunting us for many months, including 3.20 (latest) I tried today. They are still using v0.7 and not v0.9, although I was told 0.9 is included in the GIT version. Here is more information where I posted on claws bugzilla: https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4801 On that thread, I did post/attach one of the problematic mail messages I discovered, that others can use to see the problem on their own systems, which might be helpful. I can certainly provide others if needed. |
I believe this is the reduction of broken_deident_email: <table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
<table width="100%"><td>
Please bring your valid driver's license when you pick up the vehicle. If your driver's license is not issued in the US, then you must present your passport in addition to your driver's license.
It is much worse without Original broken_deident_email takes 4 sec to doc->render. So yeah, too many tables indeed. |
Just an update- we did compile the claws "git" version (master) and that does include litehtml v0.9 instead of v0.7 and it makes a HUGE improvement in rendering speed for the sample Email I provided (and that [stasoid] analyzed, above). More like 5 seconds instead of minutes. I agree that is still too slow, but it is way more tolerable :) In our case, we likely can't really use the git version in production, so we probably have to wait for the next official release of claws. But better times await us, so that is great ! Anyway, I do want to thank the litehtml team for the good work they do. |
Another update- A week ago we took our compiled litehtml plugin binaries (based on v0.9) from the git version of Claws and placed them into our production version of Claws 3.20... and it worked! So now things are rendering SO much faster, and yet inside a stable/released version of Claws. Testing over a week with 10 users has been perfect, so we will likely roll that change out for all users next week. |
The following file is HTML (github won't let me attach as .html) extracted from an e-mail.
a.txt
When opening it in claws-mail with the litehtml viewer, it takes ages (several minutes!) to show anything, and the mail client looks like it's hung.
When opening it in litebrowser, it's faster, but still seems to take a long time.
Is there a chance that you could investigate on your end if anything might explain why it's so slow?
The claws-mail stack trace looks as follows:
The text was updated successfully, but these errors were encountered: