Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextual validation of reporter flags #172

Open
leodido opened this issue Mar 23, 2023 · 0 comments
Open

Contextual validation of reporter flags #172

leodido opened this issue Mar 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@leodido
Copy link
Member

leodido commented Mar 23, 2023

Describe the feature or problem you’d like to solve

We have now --reporter (gh-pull-check,gh-pull-comment,gh-pull-review) and related flags (eg., --gh-pull-id, --gh-repo, etc.)

We need to build contextual validators so that --gh-* flags are only allowed when using the GitHub reporters.

Proposed solution

I propose to build 1 or more custom context validators on top of go-validator features.

Additional context

NONE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leodido