-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liquibase.percona.failIfNoPT
option doesn't fail the application startup in Spring Boot
#124
Comments
I've just created a integration test and the property seems to be working fine: If liquibase.percona.failIfNoPT is set to true, then the liquibase update fails with the following messages:
Note, that I used maven and liquibase-maven-plugin to run the update. Which framework do you use to integrate liquibase? Is it something like Spring Boot? When no PT is found, I simply throw a RuntimeException, which should fail the update at this moment: liquibase-percona/src/main/java/liquibase/ext/percona/PerconaChangeUtil.java Lines 117 to 120 in a785697
So, you should either see the RuntimeException or the log entry... |
Yes, I use Spring boot
For testing purposes, I use
Before starting the application
I also tried with the command line argument, |
@adangel hi, any updates on this issue? I'd really like to try the percona out in our project, but this issue is a blocker for me |
@missingdays Still can't reproduce the problem - for me it works like a charm. Pitfalls: When you run the unit tests the application context is started. If you don't use a separate db connection, then it will just run liquibase against the very same database and without the failIfNoPT property set. So when you start it another time, the changes have already been applied. Please modify my sample project until it fails. Thanks. |
Steps to reproduce:
pt-online-schema-change
not installed on your machinepercona
, in my caseliquibase.percona.failIfNoPT
System property totrue
Excepted result:
Application startup is failed
Actual result:
Application starts as normal, without any warnings or errors in the log
Log output:
Interestingly, if I don't set
liquibase.percona.failIfNoPT
and it defaults tofalse
, a warning is loggedThe text was updated successfully, but these errors were encountered: