Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to handle NULL as a value #167

Open
mrspence opened this issue Dec 1, 2018 · 2 comments
Open

Unable to handle NULL as a value #167

mrspence opened this issue Dec 1, 2018 · 2 comments
Labels

Comments

@mrspence
Copy link

mrspence commented Dec 1, 2018

It appears the slider picker is unable to handle an empty or null starting value (please see screenshot).

<slider-picker v-model="colour"></slider-picker>
//...
data: () => {
    return {
        colour: null,
    }
}

image

It would be great if there was a default colour the picker could start from if the starting value is null (perhaps white). This should probably be opened up at the init of the component, so then we can define a different default colour if needed.

Thank-you, this is a great resource!

@ypnos
Copy link
Contributor

ypnos commented Jan 28, 2019

If I am not mistaken, 76c6526 fixes this.

@linx4200 linx4200 added the 3.0 label Mar 3, 2020
@Tofandel
Copy link

Tofandel commented Aug 4, 2021

I don't really see where in this commit this would fix it @ypnos

Also the input should not set a default color if null is passed, that would be a really unpleasant experience.. It should instead allow the null value and then we should have a prop to allow the user to clear it (or not by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants