-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task-spawning code refactoring #4475
Comments
Regarding BTW I believe your exception arises when calling RE the
The pattern for that last point is unlike general .net guidance. I'm wondering what use is that option for, and whether it even has the intended effect? |
yes, and while it is completely valid scenario, it adds one too much useless exception to ignore when we already have Task/Operation cancelled duo...
it was added in times when we had little idea about this stuff to just please everyone :). Probably it's a good idea to get rid of it in v6 finally |
We should review/fix/simplify places where we create and run Tasks, e.g.
https://github.com/linq2db/linq2db/blob/master/Source/LinqToDB/AsyncExtensions.cs#L30-L68
this leads to exceptions like:
https://github.com/linq2db/linq2db/blob/master/Source/LinqToDB/LinqExtensions.cs#L732-L735
this is not necessary, as we should always work with
IQueryProviderAsync
The text was updated successfully, but these errors were encountered: