-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamometer does not support negative block id's #63
Comments
fangyurao
changed the title
Dynamometer does NOT support negative block id's
Dynamometer does not support negative block id's
Sep 7, 2018
Will submit a PR on behalf of @fangyurao |
jojochuang
added a commit
to jojochuang/dynamometer
that referenced
this issue
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dynamometer does NOT support negative block id's, which results in blocks with negative id's never being reported by any simulated DataNode.
A change has been made to XMLParser.java in our branch of Dynamometer so that negative block id's are also dealt with.
Due to the change made above, we have to change SimulatedMultiStorageFSDataset.java as well.
In Dynamometer, each DataNode has more than 1 SimulatedStorage to manage, and this following Map is maintained by each SimulatedStorage in a simulated DataNode. Moreover, a SimulatedStorage could be involved in multiple blockpools.
Map<blockpool id, Map<block, block information>>
To access a given block (associated with a blockpool id) on a simulated DataNode, we have to
( i) determine which SimulatedStorage this given block belongs to according to its block id, and then
(ii) use the associated blockpool id to retrive Map<block, block information> corresponding to the block to be accessed.
The SimulatedStorage's managed by a DataNode are arranged on an ArrayList and each SimulatedStorage on the ArrayList could be accessed by a "non-negative" integer upper-bounded by the size of that ArrayList, exclusive. To determine the SimulatedStorage a given block belongs to, the original Dynamometer simply uses (block id % number of simulated storages) as the index to access the ArrayList mentioned above. Hence, once we have a negative block id, an ArrayIndexOutOfBoundsException will be triggered. Some changes have been made in SimulatedMultiStorageFSDataset.java so that a negative block id is properly taken care of.
The text was updated successfully, but these errors were encountered: