Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote branch show null when unspecified #933

Closed
thachlp opened this issue Mar 13, 2024 · 3 comments · Fixed by #934
Closed

Remote branch show null when unspecified #933

thachlp opened this issue Mar 13, 2024 · 3 comments · Fixed by #934

Comments

@thachlp
Copy link
Member

thachlp commented Mar 13, 2024

When unspecified a branch name, the message show #null. Should we improve it?
image
@thachlp
Copy link
Member Author

thachlp commented Mar 13, 2024

In my opinion, I think we should omit #null when using the default branch. How do you think?

@minwoox
Copy link
Member

minwoox commented Mar 13, 2024

Yup, let's do that. 👍

@thachlp thachlp mentioned this issue Mar 13, 2024
Merged
@thachlp thachlp closed this as completed Jun 11, 2024
@thachlp
Copy link
Member Author

thachlp commented Jun 11, 2024

There is too long with no update, so I closed it

minwoox pushed a commit that referenced this issue Jun 13, 2024
@thachlp
Improve commit message (#934)
138eb29 
### Motivation
When unspecified a branch name on mirroring setup, the message show with `#null`, we should omit #null when using the default branch to avoid confuse.

Result
Close: #933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve commit message thachlp/centraldogma
2 participants
@thachlp @minwoox