-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record causes of failed attempts for RetryingClient
#5283
Labels
Milestone
Comments
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this issue
Jun 8, 2024
Motivation: line#5283 Modifications: - Separating `onResponse` into `onResponseOnClient` and `onResponseOnServer` as refactoring - Add `failureAttempts(Throwable error)` and `failureAttempts(HttpStatus httpstatus)` at `ClientRequestMetrics` and make us enable to record causes of failed attempts Result: - Closes line#5283 - The metrics for failed requests while retrying now include the cause of the failure. Co-authored-by: jrhee17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Only the number of failure attempts is recorded, it is difficult to know why the attempts failed.
armeria/core/src/main/java/com/linecorp/armeria/internal/common/metric/RequestMetricSupport.java
Line 171 in 90969d1
It would be good if the cause was recorded as a tag of the meter.
The text was updated successfully, but these errors were encountered: