adds clang-tidy lint

Author: tsl

.bazelrc

@@ -1 +1 @@
-build --cxxopt='-std=c++17' --compilation_mode=opt
+build --cxxopt='-std=c++17' --compilation_mode=opt --repo_env=CC=clang-10 --repo_env=CXX=clang++-10

.github/workflows/bazel.yml

@@ -17,7 +17,12 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v1
+    - name: Install clang
+      run: |
+        sudo apt install clang-10
+
+    - name: Checkout
+      uses: actions/checkout@v1
 
     - name: Mount bazel cache
       uses: actions/cache@v1
@@ -39,3 +44,7 @@ jobs:
     - name: Test
       run: |
         "${GITHUB_WORKSPACE}/bin/bazel" test --test_output=errors //painty/...
+
+    # - name: Lint
+    #   run: |
+    #    ./tools/lint-clang-tidy.sh

WORKSPACE.bazel

@@ -47,14 +47,16 @@ http_archive(
    strip_prefix = "eigen-3.3.7-patched",
    # urls = ["https://gitlab.com/thomas.lindemeier/eigen/-/archive/3.3.7-patched/eigen-3.3.7-patched.tar.gz"],
    # usually the urls above should be used. However, bazel is not able to download from gitlab and I therefore use an url to a copy of the archive for now.
-   urls =["https://gist.github.com/lindemeier/e1c3506ea6b0e20a6b08d1ac142c8380/raw/ca1779dbb9964a5df4f950bfebd5833ad7f79528/eigen-3.3.7-patched.tar.gz"]
+   urls =["https://gist.github.com/lindemeier/e1c3506ea6b0e20a6b08d1ac142c8380/raw/ca1779dbb9964a5df4f950bfebd5833ad7f79528/eigen-3.3.7-patched.tar.gz"],
+   sha256 = "0be9ab513cd911d55a15b80b67c8ffa7f8168b00bbd8c1cd9359b3081b2df8c1"
 )
 
 # OpenCV source release
 http_archive(
    name = "opencv",
    build_file_content = all_content,
    strip_prefix = "opencv-4.4.0",
+   sha256 = "7faa0991c74cda52313ee37ef73f3e451332a47e7aa36c2bb2240b69f5002d27",
    urls = ["https://github.com/opencv/opencv/archive/4.4.0.zip"],
 )
 
@@ -64,3 +66,11 @@ git_repository(
     remote = "https://github.com/google/googletest",
     branch = "v1.10.x",
 )
+
+# dependency for generating compilation database
+http_archive(
+    name = "com_grail_bazel_compdb",
+    strip_prefix = "bazel-compilation-database-0.4.5",
+    urls = ["https://github.com/grailbio/bazel-compilation-database/archive/0.4.5.tar.gz"],
+    sha256 = "bcecfd622c4ef272fd4ba42726a52e140b961c4eac23025f18b346c968a8cfb4"
+)

painty.bzl

@@ -1,4 +1,7 @@
-painty_copts = ["-Wall", "-Werror"]
+# gcc
+# painty_copts = ["-Wall", "-Werror"]
+#
+painty_copts = ["-Wall", "-Werror", "-Weverything", "-Wno-c++98-compat", "-Wno-padded", "-Wno-documentation", "-Wno-global-constructors"]
 
 def painty_cc_library(
         name,

painty/BUILD.bazel

@@ -0,0 +1,17 @@
+load("@com_grail_bazel_compdb//:aspects.bzl", "compilation_database")
+
+compilation_database(
+    name = "painty_comdb",
+    targets = [
+        "//painty/core:painty_core",
+        "//painty/image:painty_image",
+        "//painty/io:painty_io",
+        "//painty/renderer:painty_renderer"
+    ],
+    # [Optional]
+    # If your exec root (value returned by `bazel info execution_root`)
+    # is constant across your users, then you can supply the value here.
+    # Otherwise, the default is `__EXEC_ROOT__` which you can replace in
+    # the output file using `sed` or similar tool (see below).
+    exec_root = "__EXEC_ROOT__",
+)

tools/lint-clang-tidy.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+workspace_dir=$(bazel info workspace)
+
+cd $workspace_dir
+
+# generate compile_commands.json
+bazel build //painty:painty_comdb
+
+# get the compile_commands.json
+compile_commands_outfile="$(bazel info bazel-bin)/painty/compile_commands.json"
+echo "Compilation database in "$compile_commands_outfile" is ready."
+
+# post process the compilation commands file.
+# __EXEC_ROOT__ needs to be replaced with the directory containing the sources.
+sed -i -- "s|__EXEC_ROOT__|$workspace_dir|g" $compile_commands_outfile
+
+if [ -z "${CLANG_TIDY:=$(which clang-tidy)}" ]; then
+  echo "Unable to find clang-tidy" 1>&2
+  exit 1
+fi
+
+# get all relevant files and let clang-tidy process those
+find $workspace_dir/painty -regex '.*\.\(cpp\|h\|hpp\|cc\|cxx\)' -exec $CLANG_TIDY -p $compile_commands_outfile -fix  -fix-errors -extra-arg=-std=c++17 -extra-arg=-isystem -extra-arg=-I$workspace_dir {}  \;
+
+exit 0