Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single template per-email and localise it within the template #691

Open
ericlinagora opened this issue Oct 14, 2024 · 7 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ericlinagora
Copy link
Contributor

Currently e-mail templates exist in versions for en and fr. This ticket is about making a single template, and from within it calling translation labels (already available in the backend though rarely used).

related: #402

@ericlinagora ericlinagora added enhancement New feature or request good first issue Good for newcomers labels Oct 14, 2024
@Popokok
Copy link

Popokok commented Nov 18, 2024

Hi, I would like to work on this issue.

@ericlinagora
Copy link
Contributor Author

Sure, welcome

@Popokok
Copy link

Popokok commented Nov 19, 2024

Hi. I'm pretty sure I know how to deal with this issue, but I ran into a problem. I can't find a way how to test it. Do you perhaps have any ideas?

@ericlinagora
Copy link
Contributor Author

Hi, if this value https://github.com/linagora/twake-drive/blob/main/tdrive/backend/node/config/default.json#L114 is true, it should print emails in the logs. Heads up though, we're probably going to work on this soon too

@Popokok
Copy link

Popokok commented Nov 24, 2024

I got the value set as true, but I can't find the logs anywhere. I thought that those e-mails generate when user grants access to files in his drive to another user and I was trying to replicate it, but I couldn't figure it out, so I think I'm misunderstanding something. Could you please specify when are those e-mails generated and where can I find the logs of them being sent?
Thank you.

@ericlinagora
Copy link
Contributor Author

It seems we had a few bugs in the debug e-mail output, I fixed them in this commit fdccfa5 . Sorry about that.

@Popokok
Copy link

Popokok commented Nov 25, 2024

Are those logs supposed to be stdout, because I still can't see or find them anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants