[ISSUE-1254] Move domain APIs (contacts, calendar, firebase, etc) from jmap-extensions to jmap-extensions-api #1339

HoussemNasri · 2024-11-26T14:04:43Z

Closes #1254

Refactoring Guidelines

Keep the API module as small as possible.
Guice modules SHOULD NOT reside in the API module.
(unless necessary) Production code SHOULD NOT depend on jmap-extensions (it should depend on jmap-extensions-api instead).
Avoid introducing new Maven modules for free (we already have MANY modules).

TODO

Add unit tests for all modified JSON serializers.
Sort dependencies.
Move Contracts
Avoid declaring version for jmap-extensions-api unnecessary

tmail-backend/jmap/extensions-api/pom.xml

tmail-backend/integration-tests/jmap/jmap-integration-tests-common/pom.xml

tmail-backend/integration-tests/webadmin/webadmin-integration-tests-common/pom.xml

tmail-backend/pom.xml

tmail-backend/webadmin/webadmin-team-mailboxes/pom.xml

tmail-backend/jmap/extensions-api/pom.xml

...test/scala/com/linagora/tmail/james/jmap/json/EmailAddressContactMessageSerializerTest.scala

HoussemNasri · 2024-11-29T12:34:32Z

It is hard to tell in which layer this class belong. It extends JmapChange so it is clearly an implementation and Jmap-specific but is also referenced in multiple places from models on label.scala and jmap-extensions-cassandra.

tmail-backend/tmail-backend/jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/label/LabelChangeRepository.scala

Lines 30 to 34 in e4c6a99

    
           case class LabelChange(accountId: AccountId, 
        
                                  created: Set[LabelId] = Set(), 
        
                                  updated: Set[LabelId] = Set(), 
        
                                  destroyed: Set[LabelId] = Set(), 
        
                                  state: State) extends JmapChange {

I have two ideas, but can't decide which one is better:

Introduce a jmap-extensions-core that contains the common impl between the extensions- modules and place LabelChange there.
Introduce JmapLabelChange that inherits JmapChange and remove the inheritance for the existing LabelChange.

chibenwa · 2024-11-29T13:14:45Z

It is hard to tell in which layer this class belong.

Let's look at how it was solved james side.

Mailbox change is part of the API.

chibenwa · 2024-12-02T09:33:34Z

Please rebase

...c/main/scala/com/linagora/tmail/james/common/LinagoraContactAutocompleteMethodContract.scala

chibenwa

tmail-backend/jmap/extensions-api/src/main/scala/com/linagora/tmail/james/jmap/contact/EmailAddressContactEventModule.scala guice stuff is not API stuff.

Maybe it can move back?

...l-backend/jmap/extensions-api/src/main/scala/com/linagora/tmail/james/jmap/model/Label.scala

tmail-backend/jmap/jmap-extensions-configuration/pom.xml

...ons/src/test/scala/com/linagora/tmail/james/jmap/label/MemoryLabelChangeRepositoryTest.scala

...pi/src/test/scala/com/linagora/tmail/james/jmap/publicAsset/PublicAssetServiceContract.scala

chibenwa

Almost there!

Arsnael · 2024-12-10T02:27:34Z

[ERROR] Failed to execute goal io.github.evis:scalafix-maven-plugin_2.13:0.1.6_0.9.34:scalafix (scala-check-style) on project jmap-extensions-api: Scalafix invoked with errors. Check logs for details. -> [Help 1]

...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetSetMethodContract.scala

...ap/extensions/src/main/scala/com/linagora/tmail/james/jmap/label/LabelChangeRepository.scala

...end/jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/label/LabelRepository.scala

chibenwa

Again, one step closer!

chibenwa

We can IMO merge this now.

…xtensions

…objects - Use custom SetError object in JsonValidationError if any

…encies