Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redis] RedisClientFactory needs some rework #5412

Open
Arsnael opened this issue Mar 5, 2025 · 3 comments
Open

[Redis] RedisClientFactory needs some rework #5412

Arsnael opened this issue Mar 5, 2025 · 3 comments
Labels

Comments

@Arsnael
Copy link
Member

Arsnael commented Mar 5, 2025

After checking the code around, couple of things are wrong with RedisClientFactory.

Redis cluster:

  • no ssl is setup with client if specified in redis conf

Redis master/replica:

  • readFrom, ioThreads and workerThreads not used in redis client setup

Redis sentinel:

  • readFrom, ioThreads and workerThreads not used in redis client setup

Redis sentinel and master/replica have the exact same client setup (copy/paste)...

Regarding healthcheck timeouts, some seem setup with the client (standalone, cluster), some seem setup from the healthcheck (sentinel, master/replica)

Might be other things... Have a complete look other the configuration and factory of all redis topologies again and try to give it sense, with proper tests.

And try to see if proper redis client setup would help in the end solve this issue => linagora/tmail-backend#1585

@Arsnael
Copy link
Member Author

Arsnael commented Mar 7, 2025

WIP Redis backend tests refactoring: apache#2668

@Arsnael
Copy link
Member Author

Arsnael commented Mar 7, 2025

SSL for redis cluster: apache#2669

@Arsnael
Copy link
Member Author

Arsnael commented Mar 7, 2025

Except for SSL I think, not a priority for the rest. Putting back to the todo

@Arsnael Arsnael removed their assignment Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant