Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Word and WordR function to view.go #7

Open
zoli opened this issue Jan 22, 2015 · 3 comments
Open

Move Word and WordR function to view.go #7

zoli opened this issue Jan 22, 2015 · 3 comments

Comments

@zoli
Copy link
Member

zoli commented Jan 22, 2015

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7949392-move-word-and-wordr-function-to-view-go?utm_campaign=plugin&utm_content=tracker%2F7240968&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7240968&utm_medium=issues&utm_source=github).
@quarnster
Copy link
Member

IMO it'd still be useful to have these functions in buffer for non-lime users. We could create a new WordEx(seps string, offset int) Region function so that view can specify the separators to consider.

@zoli
Copy link
Member Author

zoli commented Jan 22, 2015

Totally agree, Also I think we should do the same thing for Classify method and create sth like ClassifyEx method for buffer.
IMO Word and other similar functions should use Classify method with appropriate classes, but currently Classify is using regex for detecting all classes and its slow so until moving Word function logic to Classify for CLASS_WORD_START and CLASS_WORD_END we shouldn't do that.

@quarnster
Copy link
Member

All excellent points :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants