-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't setup reverse proxy with custom domain #15
Comments
Yeah, I think I know what's causing this: If I'm right, I just need to put this behind a check to see if you've enabled the port option. I can probably also not start Nginx in this case too to save on resources. I'll take a look at this in the next few days.
This shouldn't be the case as I've not integrated the Ghostfolio auth with the Home Assistant auth. I do know you'll get a 404 as the redirect from the logout still needs some work when using ingress as it redirects to a path that isn't accessible. |
It would be better to have it as a separate addon config option. Because my nginx reverse proxy sits in the same docker instance as ghostfolio, i can point it to the docker container name and internal port without the need to expose it through the home-assistance instance. This means i do NOT configure any port in the addon config screen for proxy to work. |
Are you able to share your reverse proxy config so I can test it to be sure? |
I use https://github.com/hassio-addons/addon-nginx-proxy-manager |
Things should now work with the latest release. As noted in the PR body, you will need to enable and set the port mapping as it's a security risk exposing direct access to a port and I don't want to be responsible for the ill-informed shooting themselves in the foot. |
Thanks! V1.4.1 works great and reverse proxy is perfect. Thank you. |
Hi again,
I'm playing around with the tool, and trying to set it up in my own nginx reverse proxy where i handle all my subdomains. However, trying to point to the container port, while the favicon and page title seems to work (so the proxy itself is correctly setup) seems like the container is blocking the connection, I get a white page. Dev console just shows a 'SyntaxError: Unexpected end of JSON input'
The reason why i don't like ingress is because if i need to store usernames/passwords, like in ghostfolio, then my passwords managers just show it always that i am in home-assistant.
Also, i think due to this, whenever i 'log out' form my account in ghostfolio, it also logs me out from Home Assistant.
Thanks.
The text was updated successfully, but these errors were encountered: