Can't setup reverse proxy with custom domain

[diamant-x]

Hi again,

I'm playing around with the tool, and trying to set it up in my own nginx reverse proxy where i handle all my subdomains. However, trying to point to the container port, while the favicon and page title seems to work (so the proxy itself is correctly setup) seems like the container is blocking the connection, I get a white page. Dev console just shows a 'SyntaxError: Unexpected end of JSON input'

• Could you make it so that ingress can be enabled/disabled so that custom proxys can work?

The reason why i don't like ingress is because if i need to store usernames/passwords, like in ghostfolio, then my passwords managers just show it always that i am in home-assistant.

Also, i think due to this, whenever i 'log out' form my account in ghostfolio, it also logs me out from Home Assistant.

• Could you take a look at it as well?

Thanks.

[lildude]

• Could you make it so that ingress can be enabled/disabled so that custom proxys can work?

Yeah, I think I know what's causing this:

https://github.com/lildude/ha-addon-ghostfolio/blob/e002ff78da1092f7f54c6645feaf5731cdf6b989/rootfs/etc/services.d/ghostfolio/run#L54C1-L57C3

If I'm right, I just need to put this behind a check to see if you've enabled the port option. I can probably also not start Nginx in this case too to save on resources.

I'll take a look at this in the next few days.

Also, i think due to this, whenever i 'log out' form my account in ghostfolio, it also logs me out from Home Assistant.

This shouldn't be the case as I've not integrated the Ghostfolio auth with the Home Assistant auth. I do know you'll get a 404 as the redirect from the logout still needs some work when using ingress as it redirects to a path that isn't accessible.

[diamant-x]

If I'm right, I just need to put this behind a check to see if you've enabled the port option.

It would be better to have it as a separate addon config option. Because my nginx reverse proxy sits in the same docker instance as ghostfolio, i can point it to the docker container name and internal port without the need to expose it through the home-assistance instance. This means i do NOT configure any port in the addon config screen for proxy to work.

[lildude]

Are you able to share your reverse proxy config so I can test it to be sure?

[diamant-x]

Are you able to share your reverse proxy config so I can test it to be sure?

I use https://github.com/hassio-addons/addon-nginx-proxy-manager
Then in the GUI, i set up a proxy like:

where the hostname matches the container ID found when running the addon:

[lildude]

Things should now work with the latest release. As noted in the PR body, you will need to enable and set the port mapping as it's a security risk exposing direct access to a port and I don't want to be responsible for the ill-informed shooting themselves in the foot.

[lildude]

An even better fix is in #18 and removes all the hacking I was doing before.

#19 fixes the logout taking you to an invalid page and signing you out of HA.

[diamant-x]

Thanks! V1.4.1 works great and reverse proxy is perfect. Thank you.