Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to the NotificationHandler and option to extend the msg #211

Open
gs202 opened this issue Feb 19, 2019 · 4 comments
Open

Add option to the NotificationHandler and option to extend the msg #211

gs202 opened this issue Feb 19, 2019 · 4 comments

Comments

@gs202
Copy link

gs202 commented Feb 19, 2019

Add an option to send additional data in the notification besides the log msg (e.g. custom msg)
example:

msg = "Something is broken"
log.error("can't find parameter")

notification:

Something is broken
can't find parameter

@liiight
Copy link
Owner

liiight commented Mar 11, 2019

Not sure I get the use case

@gs202
Copy link
Author

gs202 commented Mar 11, 2019

To enrich the log message, I'd like to have more information added on top of the log message when sending the notification.
I.e, if the log message is: "can't find parameter",
My extra message is: "Something is broken, "
The notification will be ""Something is broken, can't find parameter"

@liiight
Copy link
Owner

liiight commented Jun 23, 2019

Looking into this now. Seems it would be kinda tricky to define this in a generic way, since each developer has different body. Would you add it to email subject? To push notification as a prefix/suffix? Seems like this should be handled by the notification sender

@breezko
Copy link

breezko commented Oct 16, 2019

I'd llike to get my hands dirty on it,
so what is the expected result? @liiight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants