Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display chart types as icons at the top of the config panel & use accordions instead of tabs #9569

Open
2 tasks
PriPatel opened this issue Mar 28, 2024 · 5 comments

Comments

@PriPatel
Copy link
Contributor

PriPatel commented Mar 28, 2024

https://www.figma.com/file/rlqMIJ4pm3t8aAsiMd3CZJ/Lightdash-Product-New?type=design&node-id=4-79&mode=design&t=eU5N86sswwOTdcLA-0

  • Show chart types up top as icons
  • Change category types tabs to accordions
@joaoviana joaoviana changed the title Display chart types as icons at the top of the config panel Display chart types as icons at the top of the config panel & use accordions instead of tabs Apr 8, 2024
@hamzahc1
Copy link
Contributor

hamzahc1 commented Apr 8, 2024

why is this blocked @joaoviana ?

@joaoviana
Copy link
Contributor

@hamzahc1 just waiting on Design review from @PriPatel, which will happen on or after Wednesday 10th April!

@PriPatel
Copy link
Contributor Author

PriPatel commented Apr 8, 2024

@joaoviana Im blocked on other stuff so had a bit of time to come up with some next steps:

  • The gap between each icon button should be larger. The start of the first button icon and the end of the last button icon should line up nicely with the panel's header (use the screenshot attached here for reference)
Screenshot 2024-04-08 at 16 41 09
  • The outline of the buttons should be the old light-grey. (again use the attached screenshot for reference).
  • The icon should be the old, original size ( im probably wrong but they just look a lot smaller than before!)
  • New one! There should only be one accordion open at a time. when I open one, the other one should close
  • New one! Move Reference lines into it's own accordion
  • New one! The Layout accordion should be open by default. (when I open the chart config panel)

I'll do the next review on wednesday :)

@PriPatel
Copy link
Contributor Author

PriPatel commented Apr 11, 2024

Next steps Raw dump: (WIP)

  • It's great that the chart config panel / are the same width now, but when I hover over the chart config edge, it looks like I am able to resize it. When I try and resize it, im actually resizing the metrics/dims panels and its confusing!
  • Change Grid accordion copy to Margin

@PriPatel PriPatel assigned PriPatel and unassigned joaoviana Apr 11, 2024
@PriPatel
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants