Skip to content

Commit fd418cd

Browse files
committed
fix tests for min version
1 parent 2104236 commit fd418cd

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

composer.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
"require-dev": {
2929
"symfony/browser-kit": "~2.7|~3.0|~4.0",
3030
"symfony/finder": "~2.7|~3.0|~4.0",
31+
"symfony/filesystem": "~2.7|~3.0|~4.0",
32+
"symfony/routing": "~2.7|~3.0|~4.0",
3133
"phpunit/phpunit": "^5.7",
3234
"php-coveralls/php-coveralls": "~2.0"
3335
},

src/LightSaml/SymfonyBridgeBundle/Resources/config/system.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ services:
99
class: Symfony\Component\EventDispatcher\EventDispatcher
1010

1111
lightsaml.system.logger:
12-
alias: logger
12+
class: Psr\Log\NullLogger

tests/LightSaml/SymfonyBridgeBundle/Tests/DependencyInjection/LightSamlSymfonyBridgeExtensionTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,11 +257,12 @@ public function test_loads_system_custom_event_dispatcher()
257257
$this->assertEquals($expectedAlias, (string) $containerBuilder->getAlias('lightsaml.system.event_dispatcher'));
258258
}
259259

260-
public function test_loads_system_logger()
260+
public function test_loads_system_logger_when_given_in_config()
261261
{
262262
$containerBuilder = new ContainerBuilder(new ParameterBag());
263263
$extension = new LightSamlSymfonyBridgeExtension();
264264
$config = $this->getDefaultConfig();
265+
$config['light_saml_symfony_bridge']['system']['logger'] = 'some.logger';
265266

266267
$extension->load($config, $containerBuilder);
267268

tests/LightSaml/SymfonyBridgeBundle/Tests/Functional/FunctionalTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
use Psr\Log\LoggerInterface;
3232
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
3333
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
34+
use Symfony\Component\Filesystem\Filesystem;
3435

3536
class FunctionalTest extends WebTestCase
3637
{
@@ -39,6 +40,8 @@ protected function setUp()
3940
parent::setUp();
4041
$_SERVER['KERNEL_CLASS'] = TestKernel::class;
4142
$_SERVER['KERNEL_DIR'] = __DIR__;
43+
$fs = new Filesystem();
44+
$fs->remove(__DIR__.'/cache');
4245
}
4346

4447
protected static function getKernelClass()

0 commit comments

Comments
 (0)