Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated JS stuff #526

Open
mariusdanciu opened this issue May 17, 2010 · 7 comments
Open

Remove deprecated JS stuff #526

mariusdanciu opened this issue May 17, 2010 · 7 comments
Assignees
@Shadowfiend
Labels
P:Normal T:Defect

Comments

@mariusdanciu
Copy link
Member

Remove the following deprecations:

  1. JQueryLeft, JQueryRight
  2. JSRules.fadeTime, JsRules.prefadeDuration as we have the generic auto fadeout mechanism
  3. Remove JqSHtml as all things are deprecated here.
@mariusdanciu
Copy link
Member Author

changed milestone to none

@github-importer
Copy link

Imported from Assembla: http://www.assembla.com/spaces/liftweb/tickets/526

@ghost ghost assigned mariusdanciu Mar 1, 2012
@ghost ghost assigned fmpwizard Jun 20, 2012
@Shadowfiend Shadowfiend added this to the 3.0-M1 milestone May 10, 2014
@Shadowfiend Shadowfiend assigned Shadowfiend and unassigned fmpwizard May 10, 2014
@Shadowfiend
Copy link
Member

I'll take this guy after #1534 goes in.

@farmdawgnation farmdawgnation modified the milestones: 3.0-M2, 3.0-M3 Nov 26, 2014
@Shadowfiend Shadowfiend modified the milestones: 3.0-M4, 3.0-M3 Jan 14, 2015
@fmpwizard fmpwizard modified the milestones: 3.0-M4, 3.0-M6 Mar 22, 2015
@Shadowfiend Shadowfiend modified the milestones: 3.0-M6, 3.0-M7 Jul 26, 2015
@farmdawgnation
Copy link
Member

Remove JqSHtml as all things are deprecated here.

Removed this.

JQueryLeft, JQueryRight

Can't find these.

JSRules.fadeTime, JsRules.prefadeDuration as we have the generic auto fadeout mechanism

The deprecated warning has been commented out on these...

@farmdawgnation
Copy link
Member

It looks like the commented out deprecation warning on fadeTime and prefadeDuration was done by @fmpwizard in 48051bd – any chance you remember why Diego?

@farmdawgnation farmdawgnation mentioned this issue Oct 27, 2015
Merged
@fmpwizard
Copy link
Member

@farmdawgnation I stand innocent :) that commit was to revert a previous commit, and then I went back through the history of that file and the first commit that commented out the deprecated message was

23bfc86#diff-d9a7c49760f4ebf04fe82c7f9c5f7797

I would assume it wasn't meant to be permanent but maybe @dpp has more info

@Shadowfiend Shadowfiend modified the milestones: 3.0-M8, 3.0-RC1 Feb 1, 2016
@Shadowfiend Shadowfiend modified the milestones: 3.1, 3.0-RC1 Feb 20, 2016
@Shadowfiend
Copy link
Member

Bleh, looks like we missed this guy so I think I'm going to drop the milestone since removing it will have to wait.

@Shadowfiend Shadowfiend removed this from the 3.1 milestone Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shadowfiend Shadowfiend

Labels
P:Normal T:Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Shadowfiend @mariusdanciu @fmpwizard @farmdawgnation @github-importer