Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter in a field does not always submit a LiftScreen form #1015

Open
pbrant opened this issue May 20, 2011 · 4 comments
Open

Enter in a field does not always submit a LiftScreen form #1015

pbrant opened this issue May 20, 2011 · 4 comments
Assignees

Comments

@pbrant
Copy link
Member

pbrant commented May 20, 2011

Thread here http://groups.google.com/group/liftweb/browse_thread/thread/74412a2fca848787

@github-importer
Copy link

Imported from Assembla: http://www.assembla.com/spaces/liftweb/tickets/1015

@ghost ghost assigned pbrant Mar 1, 2012
@Shadowfiend Shadowfiend assigned Shadowfiend and unassigned pbrant May 12, 2014
@Shadowfiend Shadowfiend added this to the 3.0-M1 milestone May 12, 2014
@Shadowfiend
Copy link
Member

I'll try and eyeball this guy soon.

@pbrant
Copy link
Member Author

pbrant commented May 12, 2014

I think this can be closed. The issue is that LiftScreen generates multiple form elements (one for each of forward, backwards, and cancel) and this confuses (some) browser's default button on default form calculation. It should be possible to have LiftScreen generate one form and use JavaScript to swap in the right action value to process on the server-side, but I'm not sure it's worth the effort given the number of complaints we've gotten about this.

In short, it's a minor issue, but relatively involved to fix.

For situations where it really matters, enter in field can be customized anyway (which is what we're doing).

@Shadowfiend
Copy link
Member

It conceptually bugs me that we're using a two-form solution, and it's a usability issue for the default state to be enter not submitting, even in some browsers… Let's keep it around and I'll see if I can have a look at some point in the 3.0 cycle.

@farmdawgnation farmdawgnation modified the milestones: 3.0-M2, 3.0-M3 Nov 26, 2014
@Shadowfiend Shadowfiend modified the milestone: 3.0-M3 Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants