Skip to content

Commit 34e92f7

Browse files
authored
refactor(optimus): update the api for backup to accept list of resources (raystack#222)
* refactor: update backup api to accept list of resources to backup * fix: fix buf lint errors * refactor: remove dry run api * refactor: return the id for backup
1 parent fabbde8 commit 34e92f7

File tree

1 file changed

+16
-33
lines changed

1 file changed

+16
-33
lines changed

odpf/optimus/core/v1beta1/backup.proto

Lines changed: 16 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,6 @@ option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_swagger) = {
2424
};
2525

2626
service BackupService {
27-
rpc BackupDryRun(BackupDryRunRequest) returns (BackupDryRunResponse) {
28-
option (google.api.http) = {
29-
post: "/v1beta1/project/{project_name}/namespace/{namespace_name}/datastore/{datastore_name}/backupDryrun"
30-
body: "*"
31-
};
32-
}
3327
rpc CreateBackup(CreateBackupRequest) returns (CreateBackupResponse) {
3428
option (google.api.http) = {
3529
post: "/v1beta1/project/{project_name}/namespace/{namespace_name}/datastore/{datastore_name}/backup"
@@ -48,43 +42,29 @@ service BackupService {
4842
}
4943
}
5044

51-
message BackupDryRunRequest {
52-
string project_name = 1;
53-
string datastore_name = 2;
54-
string resource_name = 3;
55-
string namespace_name = 4;
56-
string description = 5;
57-
bool ignore_downstream = 6 [deprecated = true];
58-
59-
// represents which downstream to be backed up.
60-
// possible values are the namespace names, *, or empty.
61-
// '*' means all namespaces are allowed, empty list means all downstream will be ignored.
62-
repeated string allowed_downstream_namespaces = 7;
63-
}
64-
65-
message BackupDryRunResponse {
66-
repeated string resource_name = 1;
67-
repeated string ignored_resources = 2;
45+
message IgnoredResource {
46+
string name = 1;
47+
string reason = 2;
6848
}
6949

7050
message CreateBackupRequest {
51+
reserved 3, 6, 8;
52+
7153
string project_name = 1;
7254
string datastore_name = 2;
73-
string resource_name = 3;
7455
string namespace_name = 4;
7556
string description = 5;
76-
bool ignore_downstream = 6 [deprecated = true];
7757
map<string, string> config = 7;
7858

79-
// represents which downstream to be backed up.
80-
// possible values are the namespace names, *, or empty.
81-
// '*' means all namespaces are allowed, empty list means all downstream will be ignored.
82-
repeated string allowed_downstream_namespaces = 8;
59+
repeated string resource_names = 9;
8360
}
8461

8562
message CreateBackupResponse {
86-
repeated string urn = 1;
87-
repeated string ignored_resources = 2;
63+
reserved 2;
64+
65+
repeated string resource_names = 1;
66+
repeated IgnoredResource ignored_resources = 3;
67+
string backup_id = 4;
8868
}
8969

9070
message ListBackupsRequest {
@@ -98,11 +78,13 @@ message ListBackupsResponse {
9878
}
9979

10080
message BackupSpec {
81+
reserved 2;
82+
10183
string id = 1;
102-
string resource_name = 2;
10384
google.protobuf.Timestamp created_at = 3;
10485
string description = 4;
10586
map<string, string> config = 5;
87+
repeated string resource_names = 6;
10688
}
10789

10890
message GetBackupRequest {
@@ -113,6 +95,7 @@ message GetBackupRequest {
11395
}
11496

11597
message GetBackupResponse {
98+
reserved 2;
99+
116100
BackupSpec spec = 1;
117-
repeated string urn = 2;
118101
}

0 commit comments

Comments
 (0)