The "Draw" filter for Advanced Search excludes draws by stalemate and insufficient mating material

[johndoknjas]

Exact URL of where the bug happened

https://lichess.org/@/ChessTheory64/search?players.a=chesstheory64&status=32&sort.field=d&sort.order=desc

https://lichess.org/@/ChessTheory64/search?players.a=chesstheory64&status=34&sort.field=d&sort.order=desc

Steps to reproduce the bug

1. If you go to the first url, you'll see two 5+5 rapid games at the top that ended in stalemate. However, changing the Result filter from Stalemate to Draw (second url) will not show these two games.
   Same story for Clock Flag, in cases where insufficient mating material makes the game a draw.

What did you expect to happen?

Stalemates and clock flags should be included as draws.

What happened instead?

They aren't. It's because stalemate and clock flags are their own type of result/status, and the query to the db uses that.

Operating system

Windows 11

Browser and version (or alternate access method)

Chrome

Additional information

No response

[mainali123]

@lenguyenthanh Is this issue related to this repo or lila-search repo?

[cymruu]

@mainali123, you didn't ask me, but I looked into this issue today and here’s what I learned. There are two ways to search for games:

1. Simple Search: Used for simple queries.
2. Advanced Search: Handled by the lila-search repository, uses under the hood Elasticsearch

When using the simple search, the following query is used:

lila/modules/game/src/main/Query.scala

Line 28 in 12a889e

def draw(u: UserId): Bdoc = user(u) ++ finished ++ F.winnerId.$exists(false)

This query works correctly because it lists all user's finished games that don't have winner eta all draws - i.e no matter how the draw occurred.

However, the lila-search repository searches for games with a selected status, which means it only returns games that ended with the selected status. Drawn games, can end with different statuses, so you don't receive all drawn user games.

[lenguyenthanh]

thanks @cymruu, your investigation is totally correct. We could solve this by making lila-search's query more sophisticated like include statemate and clock flag when searching for draw.

[mainali123]

There might be a reason for categorizing stalemates separately. Although a stalemate results in a draw, it is specifically a draw by stalemate. I'm not sure if it is the right idea to display stalemate games under the general draw category, as it could negate the use of advanced search filters.