Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Windows build #772

Closed
OCram85 opened this issue Jul 15, 2022 · 27 comments
Closed

Current Windows build #772

OCram85 opened this issue Jul 15, 2022 · 27 comments

Comments

@OCram85
Copy link

OCram85 commented Jul 15, 2022

Hey folks,
just wanted to update the embedded libressl-portable binary in my project PSCredentialStore.
Is there any way to download the latest release as a windows binary?

@Kreijstal
Copy link

try building it on mingw

@OCram85
Copy link
Author

OCram85 commented Jul 27, 2022

I tried to build it locally but couldn't get it running. I'm completely unfamiliar with the tools needed therefore (mingw, vscode based builds).
Maybe it's worth trying to set up a AppVeyor based pipeline for the windows builds?

@chipitsine
Copy link
Contributor

@OCram85
Copy link
Author

OCram85 commented Sep 9, 2022

@chipitsine: I've looked into the build artifacts from recent builds. The Testing.zip just contains some logs. Shouldn't it also contain the binaries?

@chipitsine
Copy link
Contributor

I bet the idea was to provide binaries on successful build and logs for failed build.

I'll have a look

@chipitsine
Copy link
Contributor

@OCram85 , I've changed artifacts settings in my fork, please check whether it is good for you

if ok, I'll make a PR

@OCram85
Copy link
Author

OCram85 commented Sep 12, 2022

@chipitsine: Awesome! Is it possible to attach a script which greps the libs / binaries (libcryptro*,libssl*, libtls*, openssl.exe) to get the portable win version?

... I'm asking because I guess it would make more sense to bring back the current windows portable version here, instead of forking and keeping sync the upstream changes just for building and deploying this specific win x64 version

@chipitsine
Copy link
Contributor

as for portable windows version I guess it worth separate task.
currently artifacts are not very comfortable for using and pipeline runs on evry pull request/push.

probably, windows portable should be packaged on git tags (??), also, some versioninng should happen. and final destination should be chocolatey instead of artifacts.

I'll have a look whether appveyor allows to specify file extension filters

@chipitsine
Copy link
Contributor

PR created: #789

@OCram85
Copy link
Author

OCram85 commented Sep 16, 2022

btw... what files do I need from the artifacts folder to get a usable openssl.exe / libressl ?
The last windows portable build I found was v2.5.5:

image

@chipitsine
Copy link
Contributor

I suggest to put libressl.exe to empty folder and run it.

alternatively, dependency walker can help

@chipitsine
Copy link
Contributor

"pdb" files are required for debugging purpose.

@OCram85
Copy link
Author

OCram85 commented Sep 20, 2022

Thank you for all the help.
I guess it works now for me OCram85/libressl-portable. (x64 build + SHARED_LIBS=OFF)

@chipitsine
Copy link
Contributor

I played with app veyor on releases. secure: PD+DR9Pb8syGAOUjJ6Y5d07AXR6btDzWreuPKcAOwxgANFcIrhcaABSHvsju+nrI is repo specific.

no easy way to make it friendly for forks and pull requests.

but it is good you made portable )) what I think, maybe switch to github actions (it is more friendly with secrets)... and push portable to chocolatey

@busterb
Copy link
Contributor

busterb commented Dec 11, 2022

I merged the change to retain build artifacts from appveyor, though more for the potential to make debugging build failures there easier. That's an interesting change @OCram85. I haven't played with github actions for Windows builds, I wonder if they would be better for archiving release artifacts.

@busterb
Copy link
Contributor

busterb commented Jul 5, 2023

as of #878 we now have a Windows builder github action. Is there a better way to archive tagged release builds with this mechanism? Can we stop building on Appveyor? I think the answer is yes for both, but wanted to check with you all.

@chipitsine
Copy link
Contributor

chipitsine commented Jul 6, 2023

I prefer Github actions over AppVeyor because it is easier to store secrets.

do you want me to implement tagged release build on gha ?

@OCram85
Copy link
Author

OCram85 commented Jul 7, 2023

as of #878 we now have a Windows builder github action. Is there a better way to archive tagged release builds with this mechanism? Can we stop building on Appveyor? I think the answer is yes for both, but wanted to check with you all.

Awesome, I also prefer using github actions. Do you plan to upload the windows build artifacts in the tag based github release page?

@busterb
Copy link
Contributor

busterb commented Jul 7, 2023

sure @chipitsine that would be fine if you want to send a PR. I'm honestly just fumbling about with GHA, so if you already know how to do it, that helps!

@sergeevabc
Copy link

@OCram85, could you be so kind to compile a fresh version of LibreSSL for Windows?
Your repository contains 3.5.3 (May 18th, 2022), whereas the current one is 3.8.2 (November 2nd, 2023).

@OCram85
Copy link
Author

OCram85 commented Dec 7, 2023

@sergeevabc: I just tried to sync my fork and rerun the appveyor pipeline. Unfortunately it fails and I don't have the time now to debug it.

But I noticed the github workflow run from the latest release tag here: https://github.com/libressl/portable/actions/runs/6730809293

So I guess you can pick the binary from artifacts like this:

image

@botovq botovq changed the title ❓ Current Windows build Current Windows build Dec 7, 2023
@OCram85
Copy link
Author

OCram85 commented Dec 8, 2023

@sergeevabc: Did it work for you?

@sergeevabc
Copy link

sergeevabc commented Dec 8, 2023

@OCram85, yes! It was no coincidence that I marked your previous message with a hooray icon. Just in case, I’ll attach libressl_v382_binary.zip here to make things easier for those who are desperately looking for one.

$ openssl.exe version
LibreSSL 3.8.2

$ powershell -c "(get-filehash -algorithm sha256 openssl.exe).hash"
C72977C42F61211B97437FBBD483CF8E1AE8580A3EDFD6F94F052DCA38052F2F

@chipitsine
Copy link
Contributor

I planned to make GHA release, but didn't have time yet.
let me try next weekend

@OCram85
Copy link
Author

OCram85 commented Dec 8, 2023

I also tried to create a pull request which uploads artifacts from github actions to a release. But couldn‘t make it work with so many build pipeline steps 🥹

@chipitsine
Copy link
Contributor

here we go
#965

@sergeevabc
Copy link

sergeevabc commented May 13, 2024

here we go #965

It works as expected, thank you. Just updated LibreSSL from 3.8.2 to 3.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants