Allow user to configure which ports are shown in data-picker on load.

  By default all interfaces of all devices are loaded and listed when
  opening the data-picker. In large setups this will cause high loading
  times every time the data-picker is loaded. With the following option
  this behvaiour can be changed, valid values are:

   'all', 'any', '-1'  Show all ports (default)
   'none', '0'         Don't load any ports.
    <integer> >= 0     Show port of libreNMS $device_id

  $config['plugins']['Weathermap']['show_interfaces'] = 'all';

Signed-off-by: Maximilian Wilhelm <[email protected]>

Author: BarbarossaTM

data-pick.php

@@ -18,6 +18,7 @@
 );
 
 $weathermap_config = array (
+	'show_interfaces' => 'all',
 	'sort_if_by' => 'ifAlias',
 );
 
@@ -28,6 +29,15 @@
 	'ifName',
 );
 
+$valid_show_interfaces = array (
+	'all' => -1,
+	'any' => -1,
+	'-1'  => -1,
+	#
+	'none' => 0,
+	'0'    => 0,
+);
+
 // Try to find most appropriate librenms config file
 foreach ($config_file_paths as $path) {
 	if (file_exists ($path)) {
@@ -65,9 +75,14 @@
 	chdir('plugins/Weathermap');
 	$librenms_found = TRUE;
 
-	/* Validate configuration */
+	/* Validate configuration, see defaults.inc.php for explaination */
 	if (in_array ($config['plugins']['Weathermap']['sort_if_by'], $valid_sort_if_by))
 		$weathermap_config['sort_if_by'] = $config['plugins']['Weathermap']['sort_if_by'];
+
+	if (in_array ($config['plugins']['Weathermap']['show_interfaces'], $valid_show_interfaces))
+		$weathermap_config['show_interfaces'] = $valid_show_interfaces[$config['plugins']['Weathermap']['show_interfaces']];
+	elseif (validate_device_id ($config['plugins']['Weathermap']['show_interfaces']))
+		$weathermap_config['show_interfaces'] = $config['plugins']['Weathermap']['show_interfaces'];
 }
 else {
 	$librenms_found = FALSE;
@@ -286,7 +301,7 @@ function applyDSFilterChange(objForm) {
 
 	//$SQL_picklist = "select data_local.host_id, data_template_data.local_data_id, data_template_data.name_cache, data_template_data.active, data_template_data.data_source_path from data_local,data_template_data,data_input,data_template where data_local.id=data_template_data.local_data_id and data_input.id=data_template_data.data_input_id and data_local.data_template_id=data_template.id ";
 
-	$host_id = -1;
+	$host_id = $weathermap_config['show_interfaces'];
 
 	$overlib = true;
 	$aggregate = false;
@@ -336,27 +351,21 @@ function applyDSFilterChange(objForm) {
 	print '</form><div class="listcontainer"><ul id="dslist">';
 
 	/*
-	 * Query interfaces...
+	 * Query interfaces (if we should)...
 	 */
-	$query = "SELECT devices.device_id,hostname,ports.port_id,ports.ifAlias,ports.ifIndex,ports.ifDescr,ports.deleted FROM devices LEFT JOIN ports ON devices.device_id=ports.device_id WHERE ports.disabled=0";
-
-	/* ...of specific host/device? */
-	if($host_id > 0) {
-		$query .= " AND devices.device_id='$host_id'";
-	}
-	
-	$sort_if_by = $config['plugins']['Weathermap']['sort_if_by'];
-	if (in_array ($sort_if_by, $valid_sort_if_by)) {
-		$query .= " ORDER BY hostname,ports.$sort_if_by";
-	} else {
-		$query .= " ORDER BY hostname,ports.ifAlias";
-	}
+	$result = Null;
+	if ($host_id != 0) {
+		$query = "SELECT devices.device_id,hostname,ports.port_id,ports.ifAlias,ports.ifIndex,ports.ifDescr,ports.deleted FROM devices LEFT JOIN ports ON devices.device_id=ports.device_id WHERE ports.disabled=0";
 
-	/* ...in specific order? */
-	$query .= " ORDER BY hostname,ports." . $weathermap_config['sort_if_by'];
-	$result = mysqli_query($link,$query);
+		/* ...of specific host/device? */
+		if($host_id > 0) {
+			$query .= " AND devices.device_id='$host_id'";
+		}
 
-	// print $SQL_picklist;
+		/* ...in specific order? */
+		$query .= " ORDER BY hostname,ports." . $weathermap_config['sort_if_by'];
+		$result = mysqli_query($link,$query);
+	}
 
 	$i=0;
 	if( mysqli_num_rows($result) > 0 )

defaults.inc.php

@@ -15,4 +15,16 @@
  */
 $config['plugins']['Weathermap']['sort_if_by'] = 'ifAlias';
 
+
+/* By default all interfaces of all devices are loaded and listed when
+ * opening the data-picker. In large setups this will cause high loading
+ * times every time the data-picker is loaded. With the following option
+ * this behvaiour can be changed, valid values are:
+ *
+ *  'all', 'any', '-1'	Show all ports (default)
+ *  'none', '0'		Don't load any ports.
+ *   <integer> >= 0	Show port of libreNMS $device_id
+ *
+ */
+$config['plugins']['Weathermap']['show_interfaces'] = 'all';
 ?>