Skip to content

Make it possible to add overlays only in a given orientation #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
libreliodev opened this issue Mar 14, 2015 · 8 comments
Closed

Make it possible to add overlays only in a given orientation #296

libreliodev opened this issue Mar 14, 2015 · 8 comments
Assignees
Labels

Comments

@libreliodev
Copy link
Owner

Similar to libreliodev/iOS#119

cc @intrications

@intrications
Copy link
Collaborator

I'm not sure what "overlays" means. Does it mean things like the slideshows and videos?

@libreliodev
Copy link
Owner Author

@intrications

I'm not sure what "overlays" means. Does it mean things like the slideshows and videos?

Yes, that's the term used by Adobe, so we suggest using it now (instead of "enhancements" or "enrichments")

@intrications intrications self-assigned this Apr 15, 2015
@intrications
Copy link
Collaborator

@libreliodev Is there an example to test this with?

@libreliodev
Copy link
Owner Author

@intrications

Is there an example to test this with?

Numero 162, page 2+3

@intrications
Copy link
Collaborator

Implemented but there may be out-of-memory issues #194

intrications added a commit that referenced this issue Apr 19, 2015
@libreliodev
Copy link
Owner Author

@intrications Indeed, there are out-of-memeory issues on an old Galaxy Tab. Can something be done?

@intrications
Copy link
Collaborator

I've tried switching to Picasso to load the images (which is a good idea anyway just for better code).

However, it doesn't seem to have improved the problem.

These are very large images we are displaying on top of the large images created to display the PDF. It is possible they are not being cleared out of memory correctly once they aren't on screen.

@libreliodev
Copy link
Owner Author

OK. I guess Crashlytics will tell us how critical the issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants