Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @libp2p/webrtc depends on deprecated packages #2264

Closed
SgtPooki opened this issue Nov 29, 2023 · 1 comment · Fixed by #2522
Closed

deps: @libp2p/webrtc depends on deprecated packages #2264

SgtPooki opened this issue Nov 29, 2023 · 1 comment · Fixed by #2522
Assignees
@maschad

Comments

@SgtPooki
Copy link
Member

We should remove the dependencies on deprecated packages.

I'm working on removing all the old ipld/ipfs deps from ipld-explorer-components and saw the following when npm installing:

npm WARN deprecated [email protected]: This module has been superseded by the multiformats module

I ran npm why to determine what was up:

╰─ ✔ ❯ npm why multibase
[email protected]
node_modules/multibase
  multibase@"^4.0.1" from [email protected]
  node_modules/multihashes
    multihashes@"^4.0.3" from @libp2p/[email protected]
    node_modules/@libp2p/webrtc
      @libp2p/webrtc@"^4.0.0" from the root project
    multihashes@"^4.0.3" from @libp2p/[email protected]
    node_modules/helia/node_modules/@libp2p/webrtc
      @libp2p/webrtc@"^3.1.3" from [email protected]
      node_modules/helia
        helia@"^2.1.0" from the root project

╭─    ~/c/work/p/ipfs/ipld-explorer-components    deps/refresh *4 ?4 
╰─ ✔ ❯ npm why multihashes
[email protected]
node_modules/multihashes
  multihashes@"^4.0.3" from @libp2p/[email protected]
  node_modules/@libp2p/webrtc
    @libp2p/webrtc@"^4.0.0" from the root project
  multihashes@"^4.0.3" from @libp2p/[email protected]
  node_modules/helia/node_modules/@libp2p/webrtc
    @libp2p/webrtc@"^3.1.3" from [email protected]
    node_modules/helia
      helia@"^2.1.0" from the root project
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Nov 29, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue May 2, 2024
@maschad
fix: remove deprecated lib multihashes (libp2p#2264)
b906dc2
@maschad maschad mentioned this issue May 2, 2024
Merged
3 tasks
@maschad maschad removed the need/triage Needs initial labeling and prioritization label May 7, 2024
@maschad maschad self-assigned this May 7, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 7, 2024

Waiting for #2522 to land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove deprecated multihashes library maschad/js-libp2p
3 participants
@SgtPooki @dhuseby @maschad