-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notifyOnTransient
also ignore disconnection events?
#2369
Labels
need/triage
Needs initial labeling and prioritization
Comments
Going through some of the testing for transient connections this line
does not seem to have an effect of the outcome of the test. If we would want to know whether a closing connection is transient or not the "peer:disconnect" info also needs to emit this
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version:
1.1.0 - 1.8.2
Subsystem:
registrar
Severity:
Medium/low
Description:
It seems like onDisconnect events are still emitted from transient connections shutting down even if
notifyOnTransient
is false.I am receiving onDisconnect events when failing to establish a WebRTC connection
Steps to reproduce the error:
The seems to be intended behaviour (judging by the code).
js-libp2p/packages/libp2p/src/registrar.ts
Line 167 in f27138c
Is it possible to fetch the closing connection here and skip if transient and notifyOnTransient is false ?
Feels more intuitive that connect and disconnect events are handled in the same way.
The text was updated successfully, but these errors were encountered: