Export mdnsService struct or rename the Service interface for mDNS

[melroy89]

I would like to have my own struct, where I can assign mDNS service to mdns.NewMdnsService():

type MyStruct struct {
	mdnsService *mdns.mdnsService // Error: name mdnsService not exported by package  typesinternal#UnexportedName
}

// Meaning, this is currently NOT possible
MyStruct.mdnsService = mdns.NewMdnsService(p2pHost, "something", &mDNSNotifee{host: p2pHost})
if err := MyStruct.mdnsService.Start(); err != nil {
	panic(err)
} else {
	log.Println("mDNS service started")
}

If you would expose the mdns.mdnsService struct (just like you already do expose dht.IpfsDHT), I could assign it to my own struct.

Meaning it be much easier to later call a MyStruct.mdnsService.Close() on it for example. Maybe its just me, but I think it makes sense to export a struct that is getting returned by a public function.

[melroy89]

The solution should be as simple of starting with a capital letter m so MdnsService should make it an exported MdnsService type.

EDIT: I did notice this interface now type Service interface {:

https://github.com/distractedm1nd/go-libp2p/blob/160218ead08bfc5eb74bde427b5034eb49cba61f/p2p/discovery/mdns/mdns.go#L29

But that interface name is not really uniquely named, and can easily conflict. Should I use this interface instead? If so, maybe consider renaming the interface so something like MdnsService as well. Similar to: IDService: https://github.com/distractedm1nd/go-libp2p/blob/160218ead08bfc5eb74bde427b5034eb49cba61f/p2p/protocol/identify/id.go#L91

[sukunrt]

The interface name is mdns.Service which reads okay to me. I'd argue IDService is named inappropriately.