Skip to content

Commit 37f2d86

Browse files
committed
update errors and tighten comparison threshold
1 parent 79d3604 commit 37f2d86

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

docs/source/examples.daisy_chain_mlip_fitting.ipynb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -627,16 +627,16 @@
627627
" print(file)\n",
628628
" assert Path(file).exists()\n",
629629
"\n",
630-
"\n",
631630
"ref_errors = {\n",
632631
" 'atomization_energy/atom': {\n",
633-
" 'train': {'RMSE': 0.023849550801771195, 'MAE': 0.019971738986477784, 'count': 50}, \n",
634-
" '_ALL_': {'RMSE': 0.02450676656293013, 'MAE': 0.020064544549953763, 'count': 100}, \n",
635-
" 'test': {'RMSE': 0.02514681175206184, 'MAE': 0.02015735011342974, 'count': 50}}, \n",
632+
" 'train': {'RMSE': 0.01784008096943666, 'MAE': 0.014956982529185385, 'count': 50}, \n",
633+
" '_ALL_': {'RMSE': 0.01810274269833562, 'MAE': 0.015205129586306461, 'count': 100}, \n",
634+
" 'test': {'RMSE': 0.018361647458989924, 'MAE': 0.015453276643427535, 'count': 50}}, \n",
636635
" 'forces/comp': {\n",
637-
" 'train': {'RMSE': 0.7436094643663678, 'MAE': 0.5152898115037744, 'count': 5034}, \n",
638-
" '_ALL_': {'RMSE': 0.7235685620391954, 'MAE': 0.5077753348085652, 'count': 10134}, \n",
639-
" 'test': {'RMSE': 0.7032271391631981, 'MAE': 0.500358104282353, 'count': 5100}}}\n",
636+
" 'train': {'RMSE': 0.6064186755127647, 'MAE': 0.440771517768513, 'count': 5037}, \n",
637+
" '_ALL_': {'RMSE': 0.6150461768441347, 'MAE': 0.44579797424459006, 'count': 10074}, \n",
638+
" 'test': {'RMSE': 0.6235543194385854, 'MAE': 0.450824430720667, 'count': 5037}}\n",
639+
"}\n",
640640
"\n",
641641
"print(errors)\n",
642642
"\n",
@@ -646,7 +646,7 @@
646646
" if measure_key == \"count\":\n",
647647
" continue\n",
648648
" pred_val = errors[prop_key][config_key][measure_key]\n",
649-
" assert val == approx(pred_val, abs=3e-1), f'Mismatch for ref prop {prop_key} config {config_key} measure {measure_key} ref {val} != actual {pred_val}'\n"
649+
" assert val == approx(pred_val), f'Mismatch for ref prop {prop_key} config {config_key} measure {measure_key} ref {val} != actual {pred_val}'\n"
650650
]
651651
},
652652
{

0 commit comments

Comments
 (0)