Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Psiagram to peer dependency for plugins #90

Open
liamross opened this issue Nov 13, 2018 · 0 comments
Open

Move Psiagram to peer dependency for plugins #90

liamross opened this issue Nov 13, 2018 · 0 comments
Labels
🏗 infrastructure New supporting files or utilities 🛌 low priority Not urgent to fix or implement

Comments

@liamross
Copy link
Owner

Problem

  1. Psiagram is technically a peer dependency rather than a direct dependency of the packages, since they must be used in conjunction with Psiagram
  2. Bundle size is being inaccurately displayed as it accounts for Psiagram in the bundle size

Solution

  1. Move Psiagram to peer dependency

Alternatives

  1. Don't move it, but this doesn't solve any of the problems.

Additional context

@liamross liamross added 🏗 infrastructure New supporting files or utilities 🛌 low priority Not urgent to fix or implement labels Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗 infrastructure New supporting files or utilities 🛌 low priority Not urgent to fix or implement
Projects
None yet
Development

No branches or pull requests

1 participant