Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add edge points #89

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

WIP: Add edge points #89

wants to merge 9 commits into from

Conversation

liamross
Copy link
Owner

@liamross liamross commented Nov 12, 2018 •
edited
Loading

Closes: #71

TODO

  • Write tests
  • Fix behavior when adding points (correct location, etc)
  • Fix removing point (double click to remove not working)
  • Fix click-to-add (doesn't appear until update ex. moving a node)
  • Fix drag (currently drags relative to where you clicked it, should drag underneath mouse)
  • Make sure it works with Manhattan Routing turned on

Description

Motivation and Context

  1. Need to be able to add and remove coordinate points from edges using onclicks
  2. Need to be able to drag and manipulate coordinates

Types of changes

Type of Change Changed?
Bug fix Y
New feature Y
Breaking change
Documentation update
Non-project files
Added tests

@codecov
Copy link

codecov bot commented Nov 12, 2018 •
edited
Loading

Codecov Report

Merging #89 into master will increase coverage by 0.29%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   80.53%   80.83%   +0.29%     
==========================================
  Files          25       24       -1     
  Lines         899      913      +14     
  Branches      213      214       +1     
==========================================
+ Hits          724      738      +14     
  Misses        175      175
Impacted Files Coverage Δ
packages/psiagram/src/utilities/diagramUtils.ts 99.24% <100%> (+0.11%) ⬆️
...ckages/psiagram/src/components/Paper/Paper.base.ts 79.41% <100%> (+0.07%) ⬆️
...agram/src/components/PaperError/PaperError.base.ts 43.75% <100%> (ø) ⬆️
...gram/src/components/Node/NodeAbstracts/TextNode.ts 73.07% <16.66%> (ø) ⬆️
packages/psiagram/src/components/Paper/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75de5a3...1f8642d. Read the comment docs.

@liamross liamross mentioned this pull request Jan 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ability to add additional coords to Edges via mouse click
1 participant
@liamross