Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label rectangle for Edge #53

Open
liamross opened this issue Jun 23, 2018 · 2 comments
Open

Label rectangle for Edge #53

liamross opened this issue Jun 23, 2018 · 2 comments
Assignees
Labels
📦 feature New feature or request 🛌 low priority Not urgent to fix or implement

Comments

@liamross
Copy link
Owner

liamross commented Jun 23, 2018

Is your feature request related to a problem? Please describe.

  1. No way to display label text for Edges

Describe the solution you'd like

  1. Find mid-coordinate of path (math things)
  2. Put rectangle there with white background and label text
  3. Maybe as a nice to have border should match edge color

Describe alternatives you've considered

NO ALTERNATIVES JUST DO IT

Additional context

This is low priority, as it's simply a nice-to-have implementation. Technically, anyone can implement this in their own custom shapes library built on-top of Psiagram

@liamross liamross added 📦 feature New feature or request 🏭 release: major labels Jun 23, 2018
@liamross liamross self-assigned this Jun 23, 2018
@liamross
Copy link
Owner Author

This question breaks down some of the logistics:

https://stackoverflow.com/questions/15500894/background-color-of-text-in-svg

@liamross liamross added 🏳️needs help A good issue to help with 🚨 critical Top priority to fix or implement and removed 🏭 release: major 🏳️needs help A good issue to help with labels Aug 27, 2018
@liamross
Copy link
Owner Author

Update: completed text positioning for TextLine, still needs rectangle

@liamross liamross removed the 🚨 critical Top priority to fix or implement label Oct 21, 2018
@liamross liamross added the 🛌 low priority Not urgent to fix or implement label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 feature New feature or request 🛌 low priority Not urgent to fix or implement
Projects
None yet
Development

No branches or pull requests

1 participant