1.32 not backward-compatiblie

[d215steinberg]

beforeEach(function () {
    angular
        .module("tmh-dynamic-locale-provider-holder", [
            "tmh.dynamicLocale"
        ])
        .config(['tmhDynamicLocaleProvider', function (tmhDynamicLocaleProvider) {
            tmhDynamicLocaleProvider.localeLocationPattern('base/bower_components/angular-i18n/angular-locale_{{locale}}.js');
        }]);
});

describe('...', function() {
    var tmhDynamicLocale;
    var async = new AsyncSpec(this);
        ...
    async.beforeEach(function(done) {
        module('tmh-dynamic-locale-provider-holder');

        inject(function ($injector) {
            tmhDynamicLocale = $injector.get('tmhDynamicLocale');
        }

        tmhDynamicLocale.set('en-us')
            .then(function () {
                done();
            });
    });
...
});

This worked fine with 1.30, but it times out with 1.32.

[lgalfaso]

From 0.1.30 to 0.1.32 there is only one relevant modification that is to add the method addLocalePatternValue to the provider. If you are not using, method then there are no other changes that can have cause this.

Would it be possible for you to create a plunker showing this breaking change?

[d215steinberg]

Our karma.conf.js is loading the dist version of tmhDynamicLocale. In 0.1.30, the dist version was actually 0.1.27. It seems that your asynchronous-loading change in 0.1.28 is what is breaking our tests.

[d215steinberg]

To fix the tests, I needed to make the following changes (largely inspired by angular-dynamic-locale's unit tests -- I could not manage to pull it off without resorting to the old runs-waitsFor-runs paradigm).

Using 0.1.30 (dist has version 0.1.27):

describe('...', function() {
    var tmhDynamicLocale;
    var async = new AsyncSpec(this);

    async.beforeEach(function(done) 
        module('tmhDynamicLocale');

        inject(function ($injector) {
            tmhDynamicLocale = $injector.get('tmhDynamicLocale');
        }

        tmhDynamicLocale.set('en-us')
            .then(function () {
                done();
            });
    });
    ...
    async.it('...', function(done) {
        tmhDynamicLocale.set('fr-ca')
            .then(function() {
                expect(...);
                done();
            });
    });
});

Using 0.1.32 (with correct dist, this would have been required from 0.1.28 on):

describe('...', function() {
    var tmhDynamicLocale;
    var localeSet;
    var $timeout;

    beforeEach(function() 
        module('tmhDynamicLocale');

        inject(function ($injector) {
              tmhDynamicLocale = $injector.get('tmhDynamicLocale');
              $timeout = $injector("$timeout");
        }

        runs(function () {
            tmhDynamicLocale.set('en-us')
                .then(function () {
                    localeSet = true;
                });
        });

        waitsFor(function () {
            $timeout.flush(50);
            return localeSet;
        });
    });
    ...
    it('...', function() {
        localeSet = false;

        runs(function () {
            tmhDynamicLocale.set('fr-ca')
                .then(function () {
                    localeSet = true;
                });
        });

        waitsFor(function () {
            $timeout.flush(50);
            return localeSet;
        });

        runs(function () {
            expect(...);
        });
    });
});