Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online model creator using old item names #2

Open
svenar-nl opened this issue Jan 22, 2021 · 3 comments
Open

Online model creator using old item names #2

svenar-nl opened this issue Jan 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@svenar-nl
Copy link

The following errors occurs when using item like sticks and books:

java.lang.NullPointerException: null at uk.lewdev.standmodels.parser.ModelSpawnCommandParser.parseArmourData(ModelSpawnCommandParser.java:207) ~[?:?] at uk.lewdev.standmodels.parser.ModelSpawnCommandParser.parseEntityData(ModelSpawnCommandParser.java:111) ~[?:?] at uk.lewdev.standmodels.parser.ModelSpawnCommandParser.parse(ModelSpawnCommandParser.java:74) ~[?:?] at uk.lewdev.standmodels.parser.ModelSpawnCommandParser.<init>(ModelSpawnCommandParser.java:31) ~[?:?]

@lewysDavies
Copy link
Collaborator

Hello,

Can you confirm you have followed:

When using the website - The following limitations apply:

  • You may and only use "Medium" or "Large" pieces. That means NO part can be "Small" or "Solid" otherwise it will break.
  • The command must be generated using the "Single" option.
  • When loading from a config, ensure the command is on the same line and encapsulated in ' '
  • Models must be centered on the website before being generated. Otherwise they will not spawn in centered.

Thanks

@lewysDavies lewysDavies added the question Further information is requested label Jan 25, 2021
@svenar-nl svenar-nl changed the title NPE when using items like sticks/books ~~NPE when using items like sticks/books~~ Online model creator using old item names Jan 26, 2021
@svenar-nl
Copy link
Author

Hi,

After creating a model from scratch again I found what the issue was.
It has nothing to do with items like sticks/books, rather whit the naming of items in the online model creator.
Items like trapdoor are now named oak_trapdoor and I didn't noticed this name until I looked at the generated data, whoops.

This issue is now unrelated to StandModelLib itself.
Before this issue gets closed, will new items be added to the online editor sometime? Or is the source of the model creator available?

@svenar-nl svenar-nl changed the title ~~NPE when using items like sticks/books~~ Online model creator using old item names Online model creator using old item names Jan 26, 2021
@lewysDavies
Copy link
Collaborator

Ill look into parsing the new material names when work calms down a bit!

@lewysDavies lewysDavies added enhancement New feature or request and removed question Further information is requested labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants