Search page #888
Closed
Search page #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2020 21:37
|
The search feature would be helpful because I often find myself grepping through this git repository to find specific blog pages. |
|
Thank you for the feedback! |
|
Interesting! I'm in favor of adding a search. How does this work? Is it a pure-JS search? That's pretty amazing if so. |
|
@jsha thank you! Hugo's help page https://gohugo.io/tools/search/ was really useful, and a special thanks to @sebz's and @eddiewebb's gists is needed 😄 Technically speaking:
So yes, 100% js front-end, with no external dependency. The json file is only ~1.5Mo for English (so with all blog posts), less than 500ko on the network with the compression, which is reasonable (but still require a waiting indicator) |
This was referenced Feb 4, 2020
Closed
added 2 commits
February 5, 2020 21:09
Uses do_not_search from letsencrypt#903 to: - Remove the search page from search engines - In the search page result, to not display do_not_index pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof of concept, to discuss about it, see if it may be useful.
https://deploy-preview-888--letsencrypt.netlify.com/search/
And for the 404: