-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated otelgrpc interceptors with stats handler #7235
Milestone
Comments
aarongable
pushed a commit
that referenced
this issue
May 29, 2024
Directly update: - go.opentelemetry.io/otel/* from v1.26.0 to v1.27.0 - go.opentelemetry.io/contrib/* from v0.51.0 to v0.52.0 Indirectly update: - google.golang.org/protobuf from v1.33.0 to v1.34.0 This update breaks some of our existing otel grpc interceptors, but in return allows us to use the newer grpc StatsHandler mechanism, while still filtering out health-check requests. Fixes #7235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent otelgrpc changes deprecate interceptors that we use throughout the //grpc package.
UnaryClientInterceptor
StreamClientInterceptor
UnaryServerInterceptor
StreamServerInterceptor
WithInterceptorFilter
Per documentation we should move away from these interceptors in favor of NewClientHandler and NewServerHandler.
The text was updated successfully, but these errors were encountered: