Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup.js throws a URL related error on opening Inspector (using the menu entry) #49

Closed
lirtistan opened this issue Jun 14, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@lirtistan
Copy link
Contributor

lirtistan commented Jun 14, 2024

Hi,

during bug hunting on #47 , i found a new bug in popup.js (see Screenshots on Line 291)...

Screenshot from 2024-06-14 20-57-56

Screenshot from 2024-06-14 21-01-01

that bug appeared inside my Chrome Version 125.0.6422.141 (Official Build) (64-bit), if i use the right click menu on the extension icon to visit Inspect popup, see Screenshot below...

Screenshot from 2022-09-05 17-45-26

@lirtistan lirtistan changed the title popup.js throws popup.js throws a URL related error on Inspector opening Jun 14, 2024
@lirtistan
Copy link
Contributor Author

Btw it just appears if you open the Inspector with a click on the menu entry, it doesn't appear if you right click inside the already opened popup.html.

@lirtistan lirtistan changed the title popup.js throws a URL related error on Inspector opening popup.js throws a URL related error on Inspector opening (using the menu entry) Jun 14, 2024
@lirtistan lirtistan changed the title popup.js throws a URL related error on Inspector opening (using the menu entry) popup.js throws a URL related error on opening Inspector (using the menu entry) Jun 14, 2024
@leonvogt
Copy link
Owner

Hi @lirtistan,

Thanks for reporting this.
I just merged #50 which should resolve this issue.
Would you mind giving this a try and see if it resolves this issue?

@leonvogt leonvogt added the bug Something isn't working label Jun 15, 2024
@lirtistan
Copy link
Contributor Author

I do gime a minute

@lirtistan
Copy link
Contributor Author

It works now, error is gone. Tyvm ❤️

@leonvogt
Copy link
Owner

Awesome, thank you @lirtistan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants