Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ipynb support #120

Open
siritoei opened this issue Oct 22, 2022 · 14 comments · May be fixed by #121
Open

Add .ipynb support #120

siritoei opened this issue Oct 22, 2022 · 14 comments · May be fixed by #121
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@siritoei
Copy link

Still doesn't working with Jupyter Notebook .ipynb files?
Now, It only shows Idle status.

@xhayper
Copy link
Collaborator

xhayper commented Oct 23, 2022

ah ig i havent adde ipynb support, will work on it.

@xhayper xhayper added the enhancement New feature or request label Oct 23, 2022
@xhayper xhayper changed the title Working on .ipynb not showing activity Add .ipynb suooirt Oct 23, 2022
@xhayper xhayper changed the title Add .ipynb suooirt Add .ipynb support Oct 23, 2022
@xhayper xhayper linked a pull request Oct 23, 2022 that will close this issue
5 tasks
@siritoei
Copy link
Author

Great job!!, now it works.

@siritoei siritoei reopened this Oct 23, 2022
@xhayper
Copy link
Collaborator

xhayper commented Oct 23, 2022

this support for ipynb still needs tons of planning and work, we are planning to support ipynb variables too, so this gonna make a while.

@siritoei
Copy link
Author

It showed {filename} of .ipynb when I opened VScode. But after I reload the required extension It doesn't work again and just shows the idle state as before. I will wait. Thank you!

@xhayper
Copy link
Collaborator

xhayper commented Oct 23, 2022

beware that ipynb is not high priority right now, because v5 just came out, right now trying to find all bug and fix it is high priority,

also ipynb support would require tons of codebase change too

@xhayper xhayper added the help wanted Extra attention is needed label Feb 18, 2023
@xhayper xhayper pinned this issue Feb 18, 2023
@xhayper xhayper mentioned this issue Jul 3, 2023
@Infinitay
Copy link

I noticed that ipynb is listed within the languages file https://github.com/leonardssh/vscord/blob/main/src/data/languages.json but it still isn't working. At least, when you're running a cell.

@xhayper
Copy link
Collaborator

xhayper commented Sep 20, 2023

VSCode has intergration with jupyter notebook and requires other api to check the jupyter notebook status which might explain why it doesnt show status when running one

@Cyanosite
Copy link

Is this being worked on or does the above mentioned issue prevent this feature from ever working?

@AvishakeAdhikary
Copy link

I find it hard to believe that this doesn't work. I just checked @Infinitay 's mentioned link and made a wild guess without checking the actual code that this might be the problem of the catching of regex patterns sequentially and it works fine on other extensions but doesn't work fine on .ipynb files. Someone please confirm if that is the issue.

@cataluna84
Copy link

I am on Ubuntu using VSCode via .deb file installation method, and I can confirm on a new installation of the extension, without the Microsoft's Jupyter Extension for Visual Studio Code, the Jupyter Notebook .ipynb files show the line number and project of the Jupyter Notebook .ipynb files, which in other words works.
But as soon as the mandatory Microsoft's Jupyter Extension for Visual Studio Code is installed to run the .ipynb files, the Discord Rich Presence extension stops working, saying on Jupyter Notebook .ipynb files that it is Idling
@xhayper

@xhayper
Copy link
Collaborator

xhayper commented Jun 17, 2024

Jupyter notebook use different api than nornal document thats why we need to add support for it

@xhayper
Copy link
Collaborator

xhayper commented Jun 17, 2024

I dont have the time nor the motivation to do it right now, i have to prepare to enter a college

@cataluna84
Copy link

I dont have the time nor the motivation to do it right now, i have to prepare to enter a college

Best of luck with the tedious process

@PCesteban
Copy link

Any updates on this? Would love to have this feature, this is the best looking rich presence plugin for vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants