Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve namespace conflict between engine and target #155

Open
leeping opened this issue Aug 3, 2019 · 0 comments
Open

Resolve namespace conflict between engine and target #155

leeping opened this issue Aug 3, 2019 · 0 comments

Comments

@leeping
Copy link
Owner

leeping commented Aug 3, 2019

FB targets usually creates the Engine object by passing a dictionary that merges the target options and engine options dictionaries. There is the potential for namespace conflicts, in particular the name key is used by both. The Engine name attribute should be renamed to engine_name and there should be some better system for resolving namespace conflicts (or there should be an error thrown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant